? Failure

User tests: Successful: Unsuccessful:

avatar AshanFernando
AshanFernando
18 Sep 2013

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in media/overrider/js/overrider.js file.

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32033&start=550

avatar AshanFernando AshanFernando - open - 18 Sep 2013
avatar mbabker
mbabker - comment - 26 Mar 2014

This pull too? Also, the .map file won't be necessary anymore as we've updated to jQuery 1.11.

avatar roland-d
roland-d - comment - 15 Aug 2014

Is this still valid?
You may blame the J!Tracker Application for transmitting this comment.

avatar AshanFernando
AshanFernando - comment - 15 Aug 2014

@mbabker Did you find any need for modifications?

avatar mbabker
mbabker - comment - 16 Aug 2014

Aside from needing synchronized to the current HEAD and removing the .map file, I think this is OK. But I don't quite remember my notes from 5 months ago that well anymore ;-)

avatar roland-d
roland-d - comment - 18 Aug 2014

I have created a new PR against staging #4128.

avatar Bakual
Bakual - comment - 18 Aug 2014

Closing in favor of #4128

avatar Bakual Bakual - close - 18 Aug 2014
avatar brianteeman brianteeman - change - 18 Aug 2014
Build .
avatar brianteeman brianteeman - change - 2 Sep 2014
Category JavaScript
avatar brianteeman brianteeman - change - 2 Sep 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Title
Removing MooTools dependencies from overrider.js
[#32033] Removing MooTools dependencies from overrider.js
avatar brianteeman brianteeman - reopen - 2 Sep 2014
avatar brianteeman brianteeman - reopen - 2 Sep 2014
avatar infograf768 infograf768 - close - 2 Sep 2014
avatar infograf768
infograf768 - comment - 2 Sep 2014

Brian, #4128 has been merged into 3.4
we do not need this one anymore. Closing..

avatar infograf768 infograf768 - change - 2 Sep 2014
Status New Closed
Closed_Date 2014-08-18 17:31:55 2014-09-02 08:46:34
avatar infograf768 infograf768 - close - 2 Sep 2014
avatar brianteeman
brianteeman - comment - 2 Sep 2014

I am just gardening not reading every word

On 2 September 2014 09:46, infograf768 notifications@github.com wrote:

Brian, #4218 has been merged into 3.4
we do not need this one anymore. Closing..


Reply to this email directly or view it on GitHub
#2001 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Add a Comment

Login with GitHub to post a comment