@BaleshSrle
I think that this pr is a hard backwards compatibility break and cannot be merged like it is at the moment.

What do you think about changing it like this:

• Adding an additional switch
  HTML4 (which should be the default setting and uses the old parameters)
  or
  HTML5 (which uses the new parameters)

• Displaying / Hiding related parameters with showon attributes in XML files.

Isn't this a B/C break with the changing of param names/values?

Then why did you inserted HTML5 Shiv in Joomla? It's job is to make the websites with html5 supportable and presentable to older web browsers (for example Internet Explorer 8 or even Internet Explorer 6). There is no need for HTML4 code, because the htm5shiv is bridging the gap between the older web browsers (pre-HTML5) an new HTML5 code structure.

For more info, you can see (and even search) on some web links:
HTML iframe tag - w3schools.com
Presentational elements and attributes - WHATWG Wiki

For those who want to see does their Joomla web-site supports HTML5 coding standard, you can find tools @ W3C Markup Validator Service & Html Validator for Firefox and Chrome.

P.S.:Inform me if you want my contribution to Joomla 4 iframe element, if you want to modernise it. If not, then I promise to you all that I will modify Joomla's iframe element after every Joomla update.

Isn't this a B/C break with the changing of param names/values?

Yes.

As implemented, this PR can't be accepted because it will cause existing sites using the wrapper component/module to stop using their existing configurations and switch to the default HTML5 configurations after an update. To be accepted in 3.x what @ReLater suggested needs to be applied.

If not, then I promise to you all that I will modify Joomla's iframe element after every Joomla update.

Why not just changing your provided code once like suggested and making all users happy including yourself? ;-)

Please leave a comment here if you don't want to change it. Maybe(!) I'll find the time to take it over.

@BaleshSrle I'm not disagreeing with you. I'm simply saying it's a B/C break as you're changing parameter names which will effect those with template overrides for those views.

@C-Lodder & @mbabker I have 17 iframe (or wrapper) elements on my 2 web-sites all together, and it took me all together less than 6 hours (maybe even less) to change all settings in every wrapper element from start to finish. Maybe you all are lazy and don't want to work on your web sites (that means to improve and maintain them).

I don't know about you, but I like to work on my web-sites.

About the template override issue, let's force the template designers to start creating templates by using HTML5 coding standard.

BTW, before I created this PR, I sent an email to admin@joomla.org informing them about this and I sent them compressed modified xml and php files, and Luca Marzo sent me an e-mail and he informed me that I need to create a PR on Joomla's GitHub.

@ReLater I started this, and I will finish this. If you wish, you can join & assist me (because I don't understand PHP, but I understand HTML). But have in mind that this needs to be lite, because some people, who are using self-hosting servers, don't have enough storage space on those servers.

It's not about being lazy, it's not about how much effort it might take a site owner to apply the changes. We have a backward compatibility promise, ONLY in a major version (i.e. 4.0) can breaking changes be accepted (preferably with a migration path if applicable). For this change proposal to land in a 3.x release, it must be made backward compatible. That means updating this PR in a way where existing HTML4 based configurations will keep working and users who elect to update their sites are free to do so with the new parameters.

Otherwise, this PR can only be applied to 4.0 if there is going to be no effort in making it backward compatible.

@mbabker I think that you are B/C this to Joomla 2.5.28. :-D

But if you like, I can create a PR for 4.0 , but after taking a glimpse at that code, I can say it is about 50% (or even more) similar to 3.x

@BaleshSrle Nothing to do with being lazy at all. It's simply obiding by semver rules.

Your changes will be fine against the 4.0-dev branch

@BaleshSrle
See #19985 please.

Closing in favor for #19985.

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19965

reopened

@BaleshSrle

A strange find with my pr #19985 but also relevant for yours if you plan to commit it for Joomla 4

Most browsers don't support overflow CSS rule for IFRAME tags. One have to use scrolling="no|yes|auto" even if it has been removed in HTML5.

See also pr #19991 (mod_wrapper, Joomla 3)

@ReLater You didn't read the link about overflow, because there is a table which displays the minimum version of web browser that supports CSS overflow property.

By the way, there is an HTML Shiv in Joomla.

You didn't read the link about overflow, because there is a table which displays the minimum version of web browser that supports CSS overflow property.

You still don't understand. overflow: hidden; doesn't hide the scroll bars of tag IFRAME (!!!!!!) in supported browsers. Test it (!!!!) WITH JOOMLA 3 and or JOOMLA 4!

If a user chooses setting Scroll Bars = NO we don't want to see scroll bars in the Joomla frontend!

That's the only criterion for your and my pr (!!!!)

It does hide it... If it doesn't, then change the dimensions of iframe element (I mean on height and/or width of iframe) and leave overflow: hidden.

Still the same answer: In Joomla 3 we have to guarantee that a user controls the behavior in backend like before. I've tested that with current Joomla 3 and HTML5 doesn't work like expected without adding HTML4 attribute
scrolling="yes"
scrolling="no"
in addition.

That's a known browsers issue, BTW.

I've closed my prs a month ago after some inverstigations because I don't like this attribute mix. But you can find their some "hints" to keep a Wrapper pr B\C for Joomla 3.

So, please feel free to provide a testable HTML5 version for Wrapper with the same common settings in backend for Joomla 3 or Joomla 4 or both. Makes no sense if we discuss theoretical things here ;-)

Look, I don't know what is the issue, but I suggest you open

link removed

in Mozilla-base (ie Firefox, Pale Moon or Sea Monkey) or Chromium-base (ie Google Chrome, Vivaldi or Opera) web browser and find the issue in my web-sites source code, because I can't find any.

Due to the nature of the link you posted I have had to remove it. Please dont post a similar link again.