Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19964] - [com_finder] - fix update inner join syntax for postgres

? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
22 Mar 2018

Summary of Changes

fix update join syntax for postgresql

Testing Instructions

  • with Content - Smart Search plugin enabled
  • index content
  • unpublish/publish a category

Expected result

no sql error

Actual result

screenshot from 2018-03-22 08-07-52

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00
avatar alikon alikon - open - 22 Mar 2018
avatar alikon alikon - change - 22 Mar 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2018
Category ⇒ Administration com_finder
avatar alikon alikon - change - 22 Mar 2018
The description was changed
avatar alikon alikon - edited - 22 Mar 2018
avatar alikon alikon - change - 22 Mar 2018
Labels Added: ?
avatar csthomas
csthomas - comment - 28 Apr 2018

I tested this PR with success but @alikon you have to add a code style fix:

FILE: ...mla-cms/administrator/components/com_finder/helpers/indexer/indexer.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 310 | WARNING | Line exceeds 150 characters; contains 155 characters
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
eabc728 29 Apr 2018 avatar alikon cs
avatar csthomas
csthomas - comment - 29 Apr 2018

I have tested this item ✅ successfully on eabc728

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19964.

avatar csthomas csthomas - test_item - 29 Apr 2018 - Tested successfully
avatar GarryMoveOut GarryMoveOut - test_item - 17 May 2018 - Tested successfully
avatar GarryMoveOut
GarryMoveOut - comment - 17 May 2018

I have tested this item ✅ successfully on eabc728

Works for me. Everything is ok. Error disappear.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19964.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 May 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 May 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 18 May 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-05-18 11:14:18
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 May 2018
avatar mbabker mbabker - merge - 18 May 2018

Add a Comment

Login with GitHub to post a comment