? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
20 Mar 2018

Revert PR; #19734 since this completely breaks the duplication check as we do not store as rawurlencode in the DB

http://mydomain.com/bogusurl
http://mydomain.com/bøgusurl

are treated separately with this PR also.

avatar tonypartridge tonypartridge - open - 20 Mar 2018
avatar tonypartridge tonypartridge - change - 20 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2018
Category Administration com_redirect
avatar infograf768
infograf768 - comment - 20 Mar 2018

Please see what #19734 solved
#19942 (comment)

IMHO, just reverting is not solving the original issue.

avatar tonypartridge
tonypartridge - comment - 20 Mar 2018

Right now, the check is broken and will lead to much bigger problems down the line if this PR stays in with potential duplicate urls to be redirected.

A solution to the reason for your PR is fine. but right now, this needs to come out.

avatar infograf768
infograf768 - comment - 20 Mar 2018

I agree that PR #19734 solved an issue and created another one. Hope you can find the solution.

avatar tonypartridge
tonypartridge - comment - 20 Mar 2018

I've found the problem, looking for a solution.

avatar tonypartridge
tonypartridge - comment - 20 Mar 2018

PR coming in soon to fix it instead.

avatar tonypartridge tonypartridge - change - 20 Mar 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-03-20 14:25:56
Closed_By tonypartridge
Labels Added: ?
avatar tonypartridge tonypartridge - close - 20 Mar 2018

Add a Comment

Login with GitHub to post a comment