User tests: Successful: Unsuccessful:
While looking at issue #19943 I saw that btn-group
for radios is again broken in J4.
I've fixed that previously with #19326, but I think with the PR to separate the layouts that PR got "reverted".
So this PR again reinstates the fix from my previous PR.
Adds proper classes to support btn-group behaviours from J3.
(copied from original PR)
To test, you can add the following code to the config.xml of any extension. Eg to /administrator/components/com_content/config.xml. Just put it right after the <config>
tag.
<fieldset
name="test"
label="Test"
>
<field
name="plain"
type="radio"
class=""
default="1"
>
<option value="1">Foo</option>
<option value="0">Bar</option>
</field>
<field
name="btn-group"
type="radio"
class="btn-group"
default="1"
>
<option value="1">Foo</option>
<option value="0">Bar</option>
</field>
<field
name="btn-group-yesno"
type="radio"
class="btn-group btn-group-yesno"
default="1"
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field
name="btn-group-yesno reordered"
type="radio"
class="btn-group btn-group-yesno"
default="1"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
<field
name="switcher"
type="radio"
class="switcher"
default="1"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
</fieldset>
Now go to the settings of that component. You will have a new tab with 5 parameters.
Check if the radios work.
Make also sure the plain radios and the switcher work as well.
All radios work
We even get some styling as expected, but main point is they work
The marked radios are not working (and styling doesn't exist).
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Title |
|
Labels |
Added:
?
|
No this is falling because of a past merge, I already fixed the test, just waiting that drone picks the right package from packagist
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-02 17:28:14 |
Closed_By | ⇒ | laoneo |
Thanks
Awesome! Thanks.
I have tested this item✅ successfully on 831743c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19946.