[#19935] - [CS] long form function return types; round 2
- Fixed in Code Base
- 25 Mar 2018
- Medium
- Build: staging
- # 19935
- Diff
- photodude:PHPCS2-more-fixn2
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes.
Summary of Changes
- Expected "boolean" but found "bool" for function return type
- Expected "integer" but found "int" for function return type
- Added some member var docBlocks to components/com_tags/views/tag/view.html.php
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-RC fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config com_search com_tags Installation Libraries Plugins |
| Labels |
Added:
?
|
||
@photodude can you please update to staging as this should solve the drone error.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19935.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19935.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 14:57:50 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 9526a8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19935.