Feeling Lucky
?
[#19934] - [CS] long form function return types; round 1
- Fixed in Code Base
- 19 Mar 2018
- Medium
- Build: staging
- # 19934
- Diff
- photodude:PHPCS2-more-fixn
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes.
Summary of Changes
- Expected "boolean" but found "bool" for function return type
- Expected "integer" but found "int" for function return type
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-RC fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_categories com_config com_fields com_finder com_installer com_languages com_menus com_modules com_redirect Modules Templates (admin) |
| Labels |
Added:
?
|
||
| Category | Administration com_associations com_banners com_categories com_config com_fields com_finder com_installer com_languages com_menus com_modules com_redirect Modules Templates (admin) | ⇒ | Administration com_associations com_banners com_categories com_config com_fields com_finder com_installer com_languages com_menus com_modules com_redirect Modules Templates (admin) Front End |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-18 19:27:27 |
| Closed_By | ⇒ | photodude |
photodude
- comment
- 18 Mar 2018
Ugh / rebase issues... I think it's fixed now
| Category | Administration com_associations com_banners com_categories com_config com_fields com_finder com_installer com_languages com_menus com_modules com_redirect Modules Templates (admin) Front End | ⇒ | Administration com_associations com_banners com_categories com_config com_fields com_finder com_installer com_languages com_menus com_modules com_redirect Modules Templates (admin) |
Quy
- comment
- 19 Mar 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19934.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-19 19:06:57 |
| Closed_By | ⇒ | zero-24 |
zero-24
- comment
- 19 Mar 2018
Merged thanks
I have tested this item✅ successfully on b149765
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19934.