[#19909] - [4.0] Fields/editor/none as custom element
- Fixed in Code Base
- 5 Apr 2018
- Medium
- Build: 4.0-dev
- # 19909
- Diff
- dgt41:fields/editor/none
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Textarea (AKA editor none) implementing the Joomla API for editors
Testing Instructions
Install from this PR's branch. Change the default editor to none. Check that the buttons work and they do:
- insert at the start of the text
- insert at the end of the text
- after making some selection and trying some of the buttons (the value from the xtd-button should replace the texture selection).
Mind that modals are not closing, it's a known issue!
Expected result
Actual result
Documentation Changes Required
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Layout Front End Plugins |
| Labels |
Added:
?
|
||
@Samgithub1997 nope, that's the default editor (tinyMCE) you need to go to Global Configuration and change the default editor to none:
Then try to insert, eg an image using the buttons bellow the editor...
Nice, so if there is no difference (there shouldn't be) then this is a passing test. All that is happening with this PR is moving the javascript form the old version (eg DOMConentLoaded) to the brand new web components. There is no other enhancement here...
Alright ! Thanks
@Samgithub1997 Thanks
Now go https://issues.joomla.org/tracker/joomla-cms/19909 and mark test result.
I have tested this item
The test was successful. It wasn't an issue but basically a necessary up-gradation from older JS version to a new web component.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19909.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19909.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19909.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19909.
@Samgithub1997 can you please retest?
I've exam in two hours. I'll test it by today
If you can fix the conflict, then we are good to go here.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-05 07:39:18 |
| Closed_By | ⇒ | laoneo |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19909.
There was a conflict, so I couldn't merge it. Dimitris fixed it.
@dgt41 Are you talking about this editor
And if you are, what exactly are you trying to test? Closing the Modal?
Please help me test your patch