[#19891] - [4.0] Session fix
- Pending
- Medium
- Build: 4.0
- # 19891
- Diff
- isacandrei:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #19769 .
Summary of Changes
A new session needs to be generated even when the last one is expired. This fix solves the problem, but I there may be a better way to do it, by changing the flow entirely when the session is expired.
The basic issue was that after a refresh of Joomla with an expired session, a new one is not generated at first, but only after the user tries to login once.
Testing Instructions
Change this line for faster expiration time.
$this->expire = 10;
Result
The login process works flawlessly after the session is expired.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries Composer Change |
| Title |
|
||||||
| Build | 4.0-dev | ⇒ | 4.0 | ||||
I'm not going to instantly close this so people can test this with patchtester. But as a general rule @isacandrei anything in libraries vendor is 3rd party code (in this case it's our own framework that lives here https://github.com/joomla-framework/session/tree/2.0-dev ) - otherwise next time we run composer install or composer update the changes will get lost
The odds of actually recreating this one in the CMS because sessions are started so early are probably slim-to-none, but as proposed this PR will cause PHP warnings to emit.
As noted in joomla-framework/session#37 I committed joomla-framework/session@63f0bba which I believe should fix this issue while avoiding the potential PHP warning.
I have tested with the new code, but the issue is not resolved. I shall investigate furthermore why the new session is not created upon refreshing a page with an expired one. Ideally, upon refresh, the warning stating that the session has expired should be shown immediately, not after a login attempt.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-21 16:26:51 |
| Closed_By | ⇒ | isacandrei | |
| Labels |
Added:
?
?
|
||
| Status | Closed | ⇒ | Pending |
changed Title so its clear what this PR is about.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19891.