Appveyor is wrong. There is no problem.

restarted Travis as it was failing

Works great (just tested subline syntax examples) but what do you think about a dropdown vs. 4 radio buttons?

Dont know why but patchtester isnt pulling all the files but looking at the code I agree with @zero-24 - it should be a dropdown

Dont know why but patchtester isnt pulling all the files

Yes i have done a clean install of the branch that solves the issue. ;)

ok, it can be a dropdown

I have tested this item ✅ successfully on 115b803

Thanks 👍

Can you please solve the conflicts comming from the merge of the other Codemirror PR?

This should be good to go. There's another update to codemirror but I don't want to make a PR for it until this gets merged.

I have tested this item ✅ successfully on 160afb8

Thanks @okonomiyaki3000 👍

Hmm. Still waiting on this, eh?

Another new version of CodeMirror is out but I won't be updating until this gets merged.
http://codemirror.net/doc/releases.html

For Default value, should it be None or Off?

Looks like I set the default value to empty string. The default text is 'Default'. CodeMirror's default is actually "default" so maybe I should double check.

With this patch applied, the editor does not display properly. Does not matter which KeyMap is selected. Tested with v3.8.8 dev.

For the plugin configuration, it is not b/c if previously enabled with the old option. You will have to reselect vim with the new option, otherwise, it will default to Default.

No, I guess I was not setting it to empty string. I don't know why I thought I was. Actually, I don't see any issue with the code but let me test it a bit and get back to you.

@Quy I could not duplicate your issue. I will rebase with the latest staging but I don't really see why it should make any difference. I don't believe there have been any other changes to CodeMirror.

Yeah, no such issue. Could you tell me which browser you're using and whether there are any messages in your javascript console?

Sorry false alarm. It is working now.

Sorry false alarm. It is working now.

@Quy so we can move this to RTC now?

and please @brianteeman do your en-GB review here so we can move forward :)

Couple of observations:

• It is not obvious what Default does. I suggested None or Off to imply key mapping is disabled.

• When configuring the plugin initially, the new option will not select vim if the old option is On. You have to reselect vim with the new option.

If these are non issues, then ok to be RTC.

It is not obvious what Default does. I suggested None or Off to imply key mapping is disabled.

But it is not 'none' or 'off'. It is CodeMirror's default. It does have some keys mapped by default. For example, Ctrl-D deletes a line, Ctrl-Z is undo, etc. Changing to a different one overwrites this. So then, with Sublime key mapping, Ctrl-D doesn't delete a line but duplicates your current selection to the next matching string. And so on.

When configuring the plugin initially, the new option will not select vim if the old option is On. You have to reselect vim with the new option.

Hmm. That's not the way I thought I coded it and it's not the way it worked when I tested it. Let's both check again.

To reproduce.

• Enable Vim Keybinding
• Apply patch
• Edit CodeMirror plugin
• Key Map is set at Default when it should be Vim

@Quy Ah, yes. You're right about that. In fact, if you were to use CodeMirror without going to the settings first, you'd still have Vim but it's true that the settings reset to default. Well, really the only way to fix that is to modify the form data in onContentPrepareData which doesn't even get fired on editor plugins so it would require adding a content plugin just for this one thing... I think not worth it.

Yes. It is not worth it. It can be a one-time quick fix by setting the new option.

I have tested this item ✅ successfully on 1b102a2

RTC