[#19819] - Add states to filter content by article ID in category model
- Closed
- 22 Mar 2022
- Medium
- Build: staging
- # 19819
- Diff
- Arkadiy-Sedelnikov:catmodel
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Add states to filter content by article ID in category model
Testing Instructions
Go to https://github.com/Joomline/JlContentFieldsFilter/
Checkout to bransh test
Download zip and install module and plugin to filtering content
Or download file here https://drive.google.com/open?id=1pJD1VedjTkqDFf-9WRStZSMKUxEteDcP
To try to filter the content by additional fields
Expected result
Filtering content articles to catrgory view
Actual result
Filtering content articles to catrgory view
Documentation Changes Required
No changes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
What to do with the two failed tests? Looked at their results, they have not found problems with my changes.
FILE: ...github.com/joomla/joomla-cms/components/com_content/models/category.php
164 | WARNING | Line exceeds 150 characters; contains 158 characters
| Labels |
Added:
?
|
||
What's wrong now? And where can I see it myself?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19819.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19819.
RTC ?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19819.
| Milestone |
Added: |
||
RTC removed for now
@brianteeman you need to change the status on the issue tracker else the bot reverse your action ;-)
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Pending |
Fixed ;-)
And what to do next?
Remove FromRequest? :) I do not see any problem to leave it.
Rewritten to getUserState()
I do not think that getUserState () is the best way out.
I think in this context getUserStateFromRequest() will be more robust
can @maintainers have a Look here please?
Is it something that can go into J4?
per comment above added "J4 Re-evaluate"-Label.
Sorry that it has taken so long to respond to this pull request. As we are not adding new features on Joomla 3, can you rebase the pr on the 4.2 branch? In the meantime I am going to close it. If ready please reopen again. Thank you for your contribution and help making Joomla better.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-22 10:01:17 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
Removed: ? ? |
||
I have tested this item✅ successfully on efc6c3e
In my opinion this is a very good solution, which will greatly expand the capabilities of plugins. Do not have to override model.
Maybe you should add something like this for com_contact?
https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/models/category.php
P.S @Arkadiy-Sedelnikov you can add a zip archive to patch description
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19819.