[#19818] - [com_ajax] Change modules check
- Fixed in Code Base
- 17 Mar 2018
- Medium
- Build: staging
- # 19818
- Diff
- Septdir:add-com_ajax-check-in-getModuleList-query
- Pending hound Hound is busy reviewing changes... Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Change modules check to ignore the Menu Assignment menu in com_ajax
Testing Instructions
- Install Joomla 3.8.5
- Download and install this test module mod_ajaxtest.zip (or you can use your module)
- Go to modules manager and then go to mod_ajaxtest settings
- Сheck Module Assignment set No pages and save module
- Apply this path
- Return to the mod_ajaxtest settings and you will see a message about a successful request
Expected result
The request will be successful regardless of the Menu Assignment
Actual result
The request is executed with an error
Module mod_ajaxtest is not published, you do not have access to it, or it's not assigned to the current menu item.
What is it for
If you honestly bothered each time to pass the itemID when I need use com_ajax in modules, if the module is form is still quite tolerable (you can make a hidden field), then in all other cases you have to be wiser.
And if you need com_ajax in the module settings. For example, some kind of field, then you have to do a third-party file handler
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Front End com_ajax |
| Title |
|
||||||
On a quick glance that seems fine.
I have tested this item
Works with my own a bit complicated ajax-module. Translations using the PHP DeepLy library for the DeepL API.
I wondered why it didn't work until I found the evil in the module check. I was happy to find this fix. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19818.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19818.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-17 15:27:35 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
This is going to break caching this query result...