Pending

User tests: Successful: Unsuccessful:

avatar wdaniels
wdaniels
25 Apr 2012

First set of patches to assist RDBMS portability as previously discussed on the general development list. This covers the following:

  • Identifier quoting of SQL reserved words:
    • LANGUAGE
    • MODULE
    • OPTION
    • TIME
    • LEVEL
    • POSITION
  • Identifier quoting of Virtuoso (and Oracle) reserved word:
    • PASSWORD
  • Quoting of string literals in some places
  • Correct use of non-standard != logic comparison operator to <>
  • Casting of some long types used in SQL functions that may not support long types
  • Fixed conditional join to categories in weblinks model (mod_weblinks seems to assume the categories table (aliased "c") is always present)
  • Fixed duplication of column list in mod_articles_news helper

These changes are organised by front/admin then by component/module/plugin but squashed into single commits with respect to the categories of changes listed above. Given that none of the categories of changes are intended to alter any functional features, I hope that this is suitably divided and correct granularity for manual testing.

If preferred the commits are available unsquashed on separate branches under wdaniels/joomla-cms as indicated by the [branch-name] prefixes of the squashed commits messages where merged into this (sql92) branch.

These patches are relatively trivial and I do not believe to be contentious. Further patch sets I intend to raise for discussion on joomla platform/cms lists as appropriate.

NB: There remains RDBMS portability issues with the use of MySQL DATE_FORMAT function in mod_relateditems and mod_weblinks which require some further investigation. Also issues remain with quoting for the LIKE conditions in mod_relateditems. No doubt other issues also remain; this patch set is not intended to be exhaustive, even with respect to the identified issues.

[JoomlaCode #28391]

avatar wdaniels wdaniels - open - 25 Apr 2012
avatar piotr-cz
piotr-cz - comment - 25 May 2012

cool, thanks!

avatar elinw
elinw - comment - 5 Oct 2012

This is so good but it would really be easier to get it in if we separated it out into components and modules. Otherwise the testing is too much for one person to do it all.

avatar nicksavov
nicksavov - comment - 29 Mar 2013

Thanks for coding this, Will!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Will!

avatar nicksavov
nicksavov - comment - 4 May 2013
avatar beat beat - reference | 2d63ec4 - 10 Sep 13
avatar phproberto phproberto - close - 3 Oct 2013
avatar phproberto
phproberto - comment - 3 Oct 2013

I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

Add a Comment

Login with GitHub to post a comment