[#197] - Add conversion of "poster" attribute URL in SEF plugin
- Closed
- 29 Mar 2013
- Medium
- Build: master
- # 197
- Diff
- ryandemmer:master
- Foreign ID 27711
User tests: Successful: Unsuccessful:
The SEF plugin does not convert the HTML5 poster attribute URL.
This commit adds the "poster" attribute to the regex alongside the "src and "href" attributes.
Tracker - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711
The tracker already exists, I have posted a response to it - http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27711
Please separate issues. We are here dealing with the sef plugin only.
I suggest you first propose the new library function to platform.
Sorry I don't know how to separate the requests and I didn't realise Github would add them together.
Should I close and re-open the pull request?
@infograf768 you should be able to just apply this patch: https://github.com/ryandemmer/joomla-cms/commit/f811241c5432521c3979d0ba1a40c6ed34612ee5.diff
@ryandemmer If you make a pull request based on a branch all new commits you push into that branch will be part of the pull request
@ryandemmer
as it is a library file patch, I suggest you create a pull to platform first.
Let's keep this one as is. I will close it after committing the part needed.
This is fixed in JoomlaCode. Thanks for coding this, Ryan! :)
Closing.
coolbung
-
Ryan, pelase create a joomalcode tracker and cross-reference here,