[#19776] - [4.0] Clean up media/system folder
- Fixed in Code Base
- 27 Feb 2018
- Medium
- Build: 4.0-dev
- # 19776
- Diff
- dgt41:system-folder/cleanup-irrelevant
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Clean up the mess in the media/system folder:
- polyfills are not joomla's code so they're moved to media/polyfills instead of media/system/polyfills
- Moved the subfolder legacy to media/legacy, obviously these files are not gonna be used anywhere in J4 core
- Moved to legacy folder the following files:
Why?
Better orginization of our codebase and also a step to actually simplify the system folder (core functionality). The remaining files in system are:
- core.js (our API + some garbage)
- cms.js The code for showOn functionality (used in singular forms, aka edit view)
- keepalive.js The code to keep a user logged in
- draggable.js, multiselect.js and searchtools.js these files are used in list views
Do you see some pattern here? Well I do...
Also there is a folder fields, but eventually this one will be removed once this task #19427 is complete.
Testing Instructions
Apply patch, test backend, everything should still work as before.
Expected result
Actual result
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_menus com_modules JavaScript Unit Tests Layout Libraries |
| Labels |
Added:
?
?
|
||
What do you think about moving the webcomponent polyfills to vendor folder?
Quite honestly I don't mind how we end up doing this. Just thinking loud J4 needs (or might need) webcomponents, fetch and promise polyfills (IIRC)
| Category | Administration com_admin com_menus com_modules JavaScript Unit Tests Layout Libraries | ⇒ | Administration com_admin com_menus com_modules JavaScript Repository Unit Tests Layout Libraries |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-27 20:37:13 |
| Closed_By | ⇒ | wilsonge |
tested and seems to work.
What do you think about moving the webcomponent polyfills to vendor folder? Or even better install them as any other 3dp lib: https://www.npmjs.com/package/@webcomponents/webcomponentsjs