? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
24 Feb 2018

Pull Request for Issue #19751

Summary of Changes

fixed behaviour when pattern attribute is not required and field is empty

Testing Instructions

  • add this field declaration to a module manifest mod_wrapper.xml for example
<field
	name="test"
	type="text"
	description="testing field validation"
	filter="string"
	label="Test"
	pattern="[A-Za-z\s0-9]+" />
  • manage/edit the mod_wrapper from backend

don't fill the test field

  • click save

Expected result

The test field to not be marked as invalid

Actual result

The test field is highlighted red and marked as invalid.

  • apply pr
  • clear cache

Result

module saved as should be

avatar alikon alikon - open - 24 Feb 2018
avatar alikon alikon - change - 24 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2018
Category JavaScript
avatar alikon alikon - change - 24 Feb 2018
Labels Added: ?
avatar Quy
Quy - comment - 27 Feb 2018

I have tested this item successfully on cf4731d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19771.

avatar Quy Quy - test_item - 27 Feb 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 4 Mar 2018

I have tested this item successfully on cf4731d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19771.

avatar Anu1601CS Anu1601CS - test_item - 4 Mar 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Mar 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Mar 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 17 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-17 15:17:24
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 17 Mar 2018
avatar mbabker mbabker - merge - 17 Mar 2018

Add a Comment

Login with GitHub to post a comment