[#19693] - Fix subform repeat counter.
- Fixed in Code Base
- 12 May 2018
- Medium
- Build: staging
- # 19693
- Diff
- Sophist-UK:fix_subform_repeat_counter
User tests: Successful: Unsuccessful:
Summary of Changes
This PR ensures that added Subform rows are numbered sequentially from zero.
Testing Instructions
Create and load a form with a repeatable subform with min=1. (Note: AFAIK, Joomla does not have any of these - I am creating one as part of a Fabrik enhancement I am working on.)
Click add twice to add a second and third row.
Examine HTML for div.subform-repeatable-group
Result before fix.
Groups are numbered 0, 2, 3
Expected result after fix.
Groups should be numbered 0, 1, 2.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
I have checked this with checkbox and checkboxes form fields and they looks fine.
And it works fine with a vanilla radio button. But when I add class="btn-group" then it doesn't work properly because the button classes do not get copied when you add a row. This is because they are not included in the template. I do not believe that this caused by this PR - I will track it down and submit a separate PR to fix it.
| Category | JavaScript | ⇒ | JavaScript Unit Tests |
| Labels |
Added:
?
|
||
I meant only a vanilla radio button.
btn-group has some extra js behind, that fail. Ignore it here.
Yes - I tested it with standard radio button and it worked fine.
AppVeyor error was not due to this PR - see log details for causes.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19693.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19693.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19693.
-
Is there a reason the title here says 3.9? (As in does it need to fix something added in 3.9/3.10 or is it a bug fix for 3.8)
-
There is a merge conflict that needs to be addressed.
| Title |
|
||||||
| Labels |
Added:
Conflicting Files
?
|
||
Merge conflict because subform-repeatable-uncompressed.js has changed elsewhere and so minified file has a conflict..
Rebased on staging, re-minifed subform-repeatable.js and did a force push.
Code changes are the same, but probably should be retested to confirm that other changes to this file have not impacted this fix.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-12 18:34:38 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Removed:
Conflicting Files
|
||
It not really important how the numbers are goes here, because after saving they will resets anyway.
But if you want to change it, then you need to test subform with radiobuttons, and checkboxes, to be sure that they continue to work correctly after this changes. Whether a radiobutons not resets after you add new row.
can use XML from one of previous pulls #16480 #7829