[#19671] - [4.0] Field category (custom fields + create new category on the fly)
- Closed
- 29 Aug 2018
- Medium
- Build: 4.0-dev
- # 19671
- Diff
- dgrammatiko:fields/custom-fields
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove the dead code, chosen that is
- Remove the inline script from custom fields
TODO
- Restore the ability to add categories on the fly
- Enhance the category creation so user can create child category (now only root cats
? are allowed) - Restore the search functionality
Testing Instructions
On an article with fields enabled try to change the category. Page reloads with or without the custom fields depending if they are assigned
Expected result
Actual result
Documentation Changes Required
???
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content com_fields JavaScript Repository |
| Labels |
Added:
?
|
||
@brianteeman this is ready for testing
| Title |
|
||||||
@dgrammatiko so is the "todo" stuff done?
Nope, this needs to be a three step process, as the other 2 todos are gonna be also custom elements (but less attached to this particular field) and thus they need to be developed in their own PRs. Just to clear things here, we still need:
- a way to add new category (a11y compliant etc)
- a way to search a long select list (probably by introducing our own joomla-select, based on the repo you pointed in that other issue)
@brianteeman how hard will it be to make chosen accessible and mobile friendly?
I mean converting it to vanilla and custom element is not a big deal: https://codepen.io/dgt41/pen/bvOdZp
why are you even thinking of that. I have already given you recommendations for fully accessible options
@brianteeman I'm gonna replace the awesomplete with the one that you are proposing in that issue but that script has nothing to do with chosen and the 3 ways we're using it in joomla. It's not even a candidate for chosen replacement...
OK @brianteeman here's something for you to evaluate:
The only problem with the suggest script (apart that it's dragging the whole PREACT with it) is that once you select something and you need to change your selection you have to manually delete (thats a lot of backspace keystrokes) to get the full list of options
We still have to implement a way to add a new category!
And also this script doesn't really work with multiple selects so for tags we need another solution...
Anyways let me know if this is something we should consider here otherwise I will revert the last commit
sorry I didnt realise you had updated this to use accessible-autocomplete - i expected to see it as a separate file. will take a look tomorrow
@dgrammatiko can you fix the conflicts please so it can be tested
@brianteeman the create new category is WIP, let me know what you think about the idea (obviously it needs a lot of polishing if this is what we want)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19671.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19671.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19671.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19671.
I retest this patch and it is not working. I have created some categories but I can't change the category of the article. On com_fields i also used a Text-Field.
- create Category on the fly: works.
- change Category: works. In the Thread above is written how: delete Category by hit Backspace, then you get existing Categories.
Test Instructions should be in first Comment.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-29 10:23:37 |
| Closed_By | ⇒ | dgrammatiko |
Is this still a WIP or is it ready for testing?