[#19648] - reCAPTCHA V1 stops on March 31
- Fixed in Code Base
- 25 Feb 2018
- Medium
- Build: staging
- # 19648
- Diff
- brianteeman:captcha
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Google have emailed directly anyone using v1 reCAPTCHA keys but users don't read their email.
This PR adds a post-installation message IF they have the reCAPTCHA plugin enabled AND they are using v1 keys.
This PR also updates the messages in the plugin informing them that V1 will not work after march 31
@mbabker already completely refactored the plugin for J4 to remove V1 etc this PR is ust for the messages
Test Instructions
- Apply this PR
- Update the db with the following sql
INSERT INTO `#__postinstall_messages` (`extension_id`, `title_key`, `description_key`, `action_key`, `language_extension`, `language_client_id`, `type`, `action_file`, `action`, `condition_file`, `condition_method`, `version_introduced`, `enabled`)
VALUES
(700, 'PLG_PLG_RECAPTCHA_VERSION_1_POSTINSTALL_TITLE', 'PLG_PLG_RECAPTCHA_VERSION_1_POSTINSTALL_BODY', 'PLG_PLG_RECAPTCHA_VERSION_1_POSTINSTALL_ACTION', 'plg_captcha_recaptcha', 1, 'action', 'site://plugins/captcha/recaptcha/postinstall/actions.php', 'recaptcha_postinstall_action', 'site://plugins/captcha/recaptcha/postinstall/actions.php', 'recaptcha_postinstall_condition', '3.9.0', 1);
- Check the Post-intallation messages in the following scenario
3.1 recaptcha plugin disabled => no message
3.2 recaptcha plugin enabled with V2 => no message
3.3 recaptcha plugin enabled with V1 => message and link
NOTE you can enter anything for the keys
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql MS SQL Language & Strings Installation Front End Plugins |
Should we not just backport the removal from J4? I mean it makes no sense to have some broken functionality in core to a disabled API.
Removing the code in full to support the dead v1 API will potentially cause sites to break because the code will be changed to forcibly try to load the v2 API dependencies no questions asked. That's a hardcoded configuration change that can be avoided, even if it comes at the cost of still allowing the dead API to be configured.
| Labels |
Added:
?
?
|
||
Note to whoever commits this - there is a "from version" value in the database where I set it to 3.9 but if its get merged in a 3.8.6 version (if that will exist) it will need to be changed
The buttons are on the same line as the text. Preferably, they should be on a separate line.
I think that's a style/parsing issue in the postinstall component, not related to this PR (I've seen something like that randomly on a few sites where I've cleared the message queue).
Wrap a <p> tag around Support for reCAPTCHA v1 will be turned off by Google on March 31, 2018. Please update the settings in the reCAPTCHA plugin to use Version 2.0. should fix the issue.
the button issue is a component issue and beyond the scope of this pr
Well the other post messages are wrapped in a <p> tag.
one is - the rest are not - and I really detest the idea of adding markup to a language string
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19648.
Can we get another test on this please as we really need to get this into 3.8.6
I have tested this item
Works as described in instructions
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19648.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-25 21:22:49 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks Brian :)
Thanks - milestone reached
added test instructions