[#19647] - Defining typeAlias in AdminModel
- Fixed in Code Base
- 26 Feb 2018
- Medium
- Build: staging
- # 19647
- Diff
- Bakual:UndefinedTypeAlias
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Currently, batch operations will generate PHP notices if the 3rd party model doesn't specify the typeAlias property for some reason.
This is because \Joomla\CMS\MVC\Model\AdminModel doesn't define the property itself.
Summary of Changes
This PR adds the property definition to the class
Testing Instructions
Test that batch operations still work.
Since core to my knowledge isn't affected, nothing should change here.
To test the appearance of the notices, you can try with my component ( (eg https://www.sermonspeaker.net/download/sermonspeaker-component/sermonspeaker-component-5-7-1.html)).
Expected result
No notice
Actual result
Notices with some 3rd party.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19647.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I tested with OSMeta Free plugin and got the notice: https://www.joomlashack.com/joomla-extensions/osmeta/
Notice: Undefined property: PluginsModelPlugin::$typeAlias in \libraries\src\MVC\Model\AdminModel.php on line 1520
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-26 03:17:00 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 1ec427b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19647.