[#19644] - [4.0] Field module order moved to custom elements
- Fixed in Code Base
- 5 Apr 2018
- Medium
- Build: 4.0-dev
- # 19644
- Diff
- dgt41:fields/module-order
User tests: Successful: Unsuccessful:
Pull Request for Issue #19427
Summary of Changes
- Moving the olde code to ES6 and custom elements
- Remove chosen (=== dead code)
Testing Instructions
Go to admin->modules, edit a module, change the position and check the order field
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules JavaScript Repository Layout |
Also, is search option removed?
Yes
| Labels |
Added:
?
|
||
@Anu1601CS good catch!
Thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19644.
Maybe I do not understand this PR right? The module field always shows only one entry, that is None. I have got three modules published on the position?
And the position field did not contain the text type or select a position
And the position field did not contain the text type or select a position
Yes that was functionality from chosen.js, we will eventually replicate it in the custom element, but right now it's not there yet
Ok, there's a bug here, will push some code later on
@Anu1601CS @astridx it should be ok now
All these things seem OK form my side. :)
console.log removed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19644.
I have tested this item
When I assigned the branch, I first saw only None in the field module ordering. I then ran npm install</tt
and executed all node build commands. Then it worked.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19644.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19644.
Can you fix conflicts here?
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19644.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-05 06:01:48 |
| Closed_By | ⇒ | laoneo |
@dgt41 what, if none of the options are selected its shows like
And this one is the previous image without the custom element.
Also, is search option removed?