? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
11 Feb 2018

Pull Request for Issue # .

Summary of Changes

Refactor the frond end part of tags:

  • Add ability to enter tags by comma or enter

  • Add ability to rearrange tags (drag and drop)

  • Make the tags fully keyboard accessible

  • Implement both ways of entering tags (through a given list or by typing)

  • New design (on hold)

  • Drop all dependencies (chosen)

  • Make it a custom element

  • Adjust backend to this changes

This is WIP meaning parts of the functionality is either not there or misbehaving

Actual result

So far: tags load form the db and rendered correctly, typed tags are not saved in the db:
screen shot 2018-02-11 at 20 35 16

Documentation Changes Required

Yes

avatar dgt41 dgt41 - open - 11 Feb 2018
avatar dgt41 dgt41 - change - 11 Feb 2018
Status New Pending
avatar dgt41 dgt41 - change - 11 Feb 2018
The description was changed
avatar dgt41 dgt41 - edited - 11 Feb 2018
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2018
Category JavaScript Repository Layout Libraries
avatar dgt41 dgt41 - change - 11 Feb 2018
The description was changed
avatar dgt41 dgt41 - edited - 11 Feb 2018
avatar dgt41 dgt41 - change - 11 Feb 2018
The description was changed
avatar dgt41 dgt41 - edited - 11 Feb 2018
avatar dgt41 dgt41 - change - 11 Feb 2018
The description was changed
avatar dgt41 dgt41 - edited - 11 Feb 2018
avatar dgt41 dgt41 - change - 11 Feb 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 11 Feb 2018

Re the draggable ordering? Is there any reason for adding this functionality iirc the order of tags has no relevance

avatar dgt41
dgt41 - comment - 11 Feb 2018

@brianteeman personally I'm not ok knowing that I cannot rearrange some data once saved. Probably low priority but I think is needed if we want to say that this component is feature complete

avatar brianteeman
brianteeman - comment - 11 Feb 2018

the question is "does rearranging the order of the tags have any effect"

avatar mbabker
mbabker - comment - 11 Feb 2018

You'd just need to save the order mapping. And for those who would prefer to be able to order these things instead of relying on input or creation order, it's a welcome minor feature.

avatar brianteeman
brianteeman - comment - 11 Feb 2018

i bring it up because we have had issues raised in the past that the content is not sorted by the ordering of the tags

avatar mbabker
mbabker - comment - 11 Feb 2018

That's still out of scope for this PR. At most this PR would introduce support for setting the display order on a content item's tags. Sorting content by tag is a much more complex task.

avatar brianteeman
brianteeman - comment - 11 Feb 2018

Thats exactly why I asked the purpose

avatar dgt41
dgt41 - comment - 11 Feb 2018

@brianteeman one very dumb example how that small change could be useful:
in the layout you check the tags and if some specific tag is first you do something differently

But as @mbabker this is solely the order that tags are presented in one item/article/etc, nothing more

avatar brianteeman
brianteeman - comment - 11 Feb 2018

you've missed what i am saying. oh well, guess i need a better way of communicating

avatar wilsonge
wilsonge - comment - 8 Aug 2018

I'm closing this for now given it's WIP that hasn't been worked on since February, there's hound errors, conflicts etc and for now our agreement to focus on the existing elements before we introduce new ones last night. Definitely we can come back to this if there is time.

avatar wilsonge wilsonge - change - 8 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-08 15:35:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Aug 2018

Add a Comment

Login with GitHub to post a comment