User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Refactor the frond end part of tags:
Add ability to enter tags by comma or enter
Add ability to rearrange tags (drag and drop)
Make the tags fully keyboard accessible
Implement both ways of entering tags (through a given list or by typing)
New design (on hold)
Drop all dependencies (chosen)
Make it a custom element
Adjust backend to this changes
So far: tags load form the db and rendered correctly, typed tags are not saved in the db:
Yes
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Layout Libraries |
Labels |
Added:
?
|
@brianteeman personally I'm not ok knowing that I cannot rearrange some data once saved. Probably low priority but I think is needed if we want to say that this component is feature complete
the question is "does rearranging the order of the tags have any effect"
You'd just need to save the order mapping. And for those who would prefer to be able to order these things instead of relying on input or creation order, it's a welcome minor feature.
i bring it up because we have had issues raised in the past that the content is not sorted by the ordering of the tags
That's still out of scope for this PR. At most this PR would introduce support for setting the display order on a content item's tags. Sorting content by tag is a much more complex task.
Thats exactly why I asked the purpose
@brianteeman one very dumb example how that small change could be useful:
in the layout you check the tags and if some specific tag is first you do something differently
But as @mbabker this is solely the order that tags are presented in one item/article/etc, nothing more
you've missed what i am saying. oh well, guess i need a better way of communicating
I'm closing this for now given it's WIP that hasn't been worked on since February, there's hound errors, conflicts etc and for now our agreement to focus on the existing elements before we introduce new ones last night. Definitely we can come back to this if there is time.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-08 15:35:31 |
Closed_By | ⇒ | wilsonge |
Re the draggable ordering? Is there any reason for adding this functionality iirc the order of tags has no relevance