[#19638] - [4.0] Setup eslint for es6
- Fixed in Code Base
- 11 Feb 2018
- Medium
- Build: 4.0-dev
- # 19638
- Diff
- dneukirchen:feature/javascript-codestyle
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Currently we are not checking the js codestyle at all. I was told that we are trying to use the airbnb codestyles. I checked media/system/core.js and it has 2300 cs errors (thats more than 2 per line) so its time to improve things here.
Airbnb code styles are widely accepted, more info: https://github.com/airbnb/javascript
This PR prepares js code style checks.
Changes
- Use airbnb eslint config
- Rename scripts
Changes to scripts
npm run compile-jsis nownpm run build:jsnpm run compile-sassis nownpm run build:css- Introduced new script
npm run lint:jsto check javascript cs (currently only for es6 and not used in ci so far) npm run update-dependenciesis nownpm run update
Documentation changes
Yes, we need to update code styles (which are outdated): https://developer.joomla.org/coding-standards/javascript.html (can be addopted from https://github.com/airbnb/javascript)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
| Title |
|
||||||
Can a small file in core being converted that we can see the new cs rules live?
I will include an example in the next PR (together with the changes required for es6 support).
for now:
- Create a file anywhere in the project
codestyle.es6.jswith the following contents:
export default class Codestyle {
sayHello() {
console.log('hello');
}
}
-
Run
npm installandnpm run lint:js -
See linting works as expected.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-11 22:16:02 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
(updated title to show 4.0)