? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
10 Feb 2018

Pull Request for Issue #

Summary of Changes

This PF fixes user profile field are optional on registration form even it is configured as a required field. This is an alternative for existing PRs #19614 and #19617. See #19617 (comment) for the reason if the error if needed.

Testing Instructions

  1. Enable user profile plugin

  2. Set address 1 field as required

  3. Try to register for an account on your site

  • Before patch: The address 1 field is displayed as optional field
  • After patch: The address 1 field becomes a required field (as configured from the plugin)
avatar joomdonation joomdonation - open - 10 Feb 2018
avatar joomdonation joomdonation - change - 10 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2018
Category Front End Plugins
avatar ggppdk
ggppdk - comment - 10 Feb 2018
  • Fixes the case of extra fields of 'User - Profile' plugin that are marked as 'required' showing wrongly as optional
  • The form reloading when form validation fails (after submiting) continues to work and the form posted data are reloaded from session (see testing instructions in #19617) (just delete a required field using the browser inspector and submit the form)
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19633.
avatar ggppdk
ggppdk - comment - 10 Feb 2018

I have tested this item successfully on b1c2063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19633.

avatar ggppdk ggppdk - test_item - 10 Feb 2018 - Tested successfully
avatar alikon
alikon - comment - 10 Feb 2018

I have tested this item successfully on b1c2063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19633.

avatar alikon alikon - test_item - 10 Feb 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Feb 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Feb 2018

Ready to Commit after two successful tests.

avatar BjornvanSchie
BjornvanSchie - comment - 11 Feb 2018

I have tested this item successfully on b1c2063

avatar mbabker mbabker - close - 13 Feb 2018
avatar mbabker mbabker - merge - 13 Feb 2018
avatar mbabker mbabker - change - 13 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-13 00:18:21
Closed_By mbabker
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment