? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
10 Feb 2018

Pull Request for Issue #19563.

Summary of Changes

Fix inputmode name from being included in the inputmode value.

This change matches how $maxLength and $dirname are implemented in \libraries\joomla\form\fields\text.php and \layouts\joomla\form\field\text.php.

Testing Instructions

In \components\com_content\models\forms\article.xml after line 37, add: inputmode="numeric"

Edit an article in the front end.
View page source.
Find inputmode attribute.

Expected result

<input type="text" name="jform[title]" id="jform_title" value="Joomla! Testing" class="inputbox required" size="30" required aria-required="true" inputmode="numeric" />

Actual result

<input type="text" name="jform[title]" id="jform_title" value="Joomla! Testing" class="inputbox required" size="30" required aria-required="true" inputmode=" inputmode="numeric"" />

Documentation Changes Required

none

avatar Quy Quy - open - 10 Feb 2018
avatar Quy Quy - change - 10 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2018
Category Layout
avatar Fedik
Fedik - comment - 10 Feb 2018

I have tested this item successfully on 0352948


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19632.

avatar Fedik Fedik - test_item - 10 Feb 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 10 Feb 2018

I have tested this item successfully on 0352948


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19632.

avatar Anu1601CS Anu1601CS - test_item - 10 Feb 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Feb 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Feb 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 13 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-13 00:17:49
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 13 Feb 2018
avatar mbabker mbabker - merge - 13 Feb 2018

Add a Comment

Login with GitHub to post a comment