? Pending

User tests: Successful: Unsuccessful:

avatar Sophist-UK
Sophist-UK
9 Feb 2018

Pull Request for Issue # .

Summary of Changes

Adds a % character to the end of the progress bar Percent-Progress commentary during a Joomla version upgrade.

Testing Instructions

Install Joomla previous to current version. Apply fix. Upgrade to current version. During upgrade the Percent-complete line below the progress bar should now end with a '%' character.

Documentation Changes Required

None.

avatar Sophist-UK Sophist-UK - open - 9 Feb 2018
avatar Sophist-UK Sophist-UK - change - 9 Feb 2018
Status New Pending
avatar joomla-cms-bot
joomla-cms-bot - comment - 9 Feb 2018

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2018
Category JavaScript
avatar Sophist-UK
Sophist-UK - comment - 9 Feb 2018

This is possibly the most trivial possible change ever even when compared to all other trivial changes. Let's not get too hung up on having loads of people regression test it.

avatar Quy
Quy - comment - 9 Feb 2018

I have tested this item successfully on 37fe9c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19628.

avatar Quy Quy - test_item - 9 Feb 2018 - Tested successfully
avatar Sophist-UK
Sophist-UK - comment - 9 Feb 2018

@Quy - thanks.

That is already 10x as much effort testing as this trivial change deserves. To be honest an eye-ball review would probably have sufficed.

avatar ggppdk
ggppdk - comment - 10 Feb 2018

I have tested this item successfully on 37fe9c6

Easy and quick to test this
Tested with patch applied the percentage appears as intended
Search through code, there is no code that tries to use the inner HTML of element, so nothing will break by this change


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19628.

avatar ggppdk ggppdk - test_item - 10 Feb 2018 - Tested successfully
avatar ggppdk
ggppdk - comment - 10 Feb 2018

Only i see an issue, not directly related to this PR

2 files exist
media/com_joomlaupdate/js/update.js
media/com_joomlaupdate/js/update.min.js

  • but update.js is loaded despite Debug being OFF, i guess this is known and discussed else ?, just i am not aware of it

Also this PR does not update file 'update.min.js'

avatar Sophist-UK
Sophist-UK - comment - 10 Feb 2018

@ggppdk - I was of the view that minimised versions should not be included in PRs because it prevents two simultaneous PRs both being mergeable - after the first PR is merged, because the minified version is all on one line, the second PR cannot be successfully diffed and so becomes unmergeable. So in my experience on other projects, the minification is typically done as part of a merge process or left for automatic generation as part of a release.

However Joomla's rules may be different - and if so, if someone points me to the specific way of minifying that Joomla uses, I would be happy to add a minified version.

avatar brianteeman
brianteeman - comment - 10 Feb 2018

Please include the minified ms in this pr and use any minified of your choice

avatar Sophist-UK Sophist-UK - change - 10 Feb 2018
The description was changed
Labels Added: ?
avatar Sophist-UK
Sophist-UK - comment - 10 Feb 2018

Added - using https://jscompress.com/

avatar wilsonge
wilsonge - comment - 10 Feb 2018

Merging with the good test + on my review

avatar wilsonge wilsonge - change - 10 Feb 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-10 13:48:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Feb 2018
avatar wilsonge wilsonge - merge - 10 Feb 2018
avatar zero-24 zero-24 - change - 12 Feb 2018
Title
[3.9] Tweak update percentage message to include %-sign
[3.8] Tweak update percentage message to include %-sign
avatar zero-24 zero-24 - edited - 12 Feb 2018

Add a Comment

Login with GitHub to post a comment