User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Adds a % character to the end of the progress bar Percent-Progress commentary during a Joomla version upgrade.
Install Joomla previous to current version. Apply fix. Upgrade to current version. During upgrade the Percent-complete line below the progress bar should now end with a '%' character.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript |
This is possibly the most trivial possible change ever even when compared to all other trivial changes. Let's not get too hung up on having loads of people regression test it.
I have tested this item
I have tested this item
Easy and quick to test this
Tested with patch applied the percentage appears as intended
Search through code, there is no code that tries to use the inner HTML of element, so nothing will break by this change
Only i see an issue, not directly related to this PR
2 files exist
media/com_joomlaupdate/js/update.js
media/com_joomlaupdate/js/update.min.js
Also this PR does not update file 'update.min.js'
@ggppdk - I was of the view that minimised versions should not be included in PRs because it prevents two simultaneous PRs both being mergeable - after the first PR is merged, because the minified version is all on one line, the second PR cannot be successfully diffed and so becomes unmergeable. So in my experience on other projects, the minification is typically done as part of a merge process or left for automatic generation as part of a release.
However Joomla's rules may be different - and if so, if someone points me to the specific way of minifying that Joomla uses, I would be happy to add a minified version.
Please include the minified ms in this pr and use any minified of your choice
Labels |
Added:
?
|
Added - using https://jscompress.com/
Merging with the good test + on my review
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-10 13:48:28 |
Closed_By | ⇒ | wilsonge |
Title |
|
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.