? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
8 Feb 2018

Pull Request for Issue space indents are not allowed

Summary of Changes

  • remove space indent exceptions
  • fix some cases where spaces indents have snuck in

Testing Instructions

merge by code review
Drone should not error as all space indent exceptions should have been fixed
A few cases had to be fixed and are included in this PR.

No more spaces once this is merged.
(except in the few cases where we have larger full file/folder exceptions across the CMS libraries and tests, etc)

Expected result

no drone CS errors

Actual result

no drone CS errors

Documentation Changes Required

none

avatar photodude photodude - open - 8 Feb 2018
avatar photodude photodude - change - 8 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category Repository
avatar photodude photodude - change - 8 Feb 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category Repository Administration com_menus Repository
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category Repository Administration com_menus Administration com_associations com_menus Repository
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category Repository Administration com_menus com_associations Administration com_associations com_menus Repository Front End com_content
avatar photodude photodude - change - 8 Feb 2018
The description was changed
avatar photodude photodude - edited - 8 Feb 2018
avatar photodude photodude - change - 8 Feb 2018
The description was changed
avatar photodude photodude - edited - 8 Feb 2018
avatar photodude
photodude - comment - 8 Feb 2018

@zero-24 @Quy This PR finalizes the work from #19350 and #19351

avatar zero-24
zero-24 - comment - 8 Feb 2018

ok merging on review. The move to multible lines can be done in a later PR as this is more a personal preference. Thanks @photodude

avatar zero-24 zero-24 - close - 8 Feb 2018
avatar zero-24 zero-24 - merge - 8 Feb 2018
avatar zero-24 zero-24 - change - 8 Feb 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-08 04:36:14
Closed_By zero-24

Add a Comment

Login with GitHub to post a comment