Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19608] - Pass the configuration tmp_path to the archive package for extension installations

? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
8 Feb 2018

Pull Request for Issue #19503

Summary of Changes

Pass the configuration tmp_path to the archive package for extension installations

Testing Instructions

Make sure extension installation still works

Expected result

extension installation uses the joomla temp folder

Actual result

extension installation uses the system / server temp folder

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 8 Feb 2018
avatar zero-24 zero-24 - change - 8 Feb 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category ⇒ Libraries
avatar waveywhite
waveywhite - comment - 8 Feb 2018

This patch doesn't work as it stands.

PHP Fatal error:  Class 'Joomla\\CMS\\Installer\\JFactory' not found in /var/www/.../httpdocs/libraries/src/Installer/InstallerHelper.php on line 135

JFactory needs a "" before it to set the correct context, like so:

		$archive = new Archive(array('tmp_path' => \JFactory::getConfig()->get('tmp_path')));
avatar zero-24 zero-24 - change - 8 Feb 2018
Labels Added: ?
avatar zero-24
zero-24 - comment - 8 Feb 2018

fixed with the last commit thanks @waveywhite

avatar joomdonation
joomdonation - comment - 11 Feb 2018

I have tested this item ✅ successfully on 4df1ded

Install works OK, the temp file is created in Joomla Temp Folder instead of system temp folder

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19608.

avatar joomdonation joomdonation - test_item - 11 Feb 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 13 Feb 2018

I have tested this item ✅ successfully on 4df1ded

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19608.

avatar Anu1601CS Anu1601CS - test_item - 13 Feb 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Feb 2018
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Feb 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - close - 26 Feb 2018
avatar mbabker mbabker - merge - 26 Feb 2018
avatar mbabker mbabker - change - 26 Feb 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-26 03:15:40
Closed_By ⇒ mbabker
Labels Added: ?

Add a Comment

Login with GitHub to post a comment