Feeling Lucky
?
[#19591] - Improve header handling in PageController cache
- Fixed in Code Base
- 26 Feb 2018
- Medium
- Build: staging
- # 19591
- Diff
- mbabker:page-controller-cache
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #17192
Summary of Changes
- Sets the 304 response header through our web application's API and sends all of the application's registered headers before exiting
- Quotes the value of the
ETagheader as should be done
Testing Instructions
Primarily code review as personally I'm not sure how to trigger the circumstances which causes this code path to be triggered
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Quy
- comment
- 15 Feb 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19591.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 15 Feb 2018
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19591.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-26 03:15:54 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on b5cf38f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19591.