? ? ? Pending

User tests: Successful: Unsuccessful:

avatar ITPrism
ITPrism
6 Feb 2018

Summary of Changes

This PR is another concept of the sidebar submenu ( #19552 ). It shows the links as navbar and adds a button that you will be able to use to show or hide that bar.

Before
35769494-71eb16d0-0914-11e8-9c95-643454370071

After
after

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar ITPrism ITPrism - open - 6 Feb 2018
avatar ITPrism ITPrism - change - 6 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2018
Category Administration com_content Language & Strings Layout Libraries
avatar dgt41
dgt41 - comment - 6 Feb 2018

Can you please post a screenshot of the page I mentioned in your previous PR: #19552 (comment)

This is essential, as I think you're overlooking what the content of the sidebar might be!

avatar C-Lodder
C-Lodder - comment - 7 Feb 2018

Much prefer this approach, although I dont think the toggle would be required at all. Also a small linear separator inbetween each item.

avatar ciar4n
ciar4n - comment - 7 Feb 2018

I like the idea. Only issues I can see with this approach..

  1. On 3PD components which have a lot of menu items, this menu can potentially wrap to a 2nd line
  2. @dgt41 point that this sidebar may contain more than menu items. Personally I would agree with #16020 (comment)

An issue on the same subject.. #16020

avatar Fedik
Fedik - comment - 7 Feb 2018

This is looks good ?

avatar ITPrism ITPrism - change - 7 Feb 2018
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2018
Category Administration com_content Language & Strings Layout Libraries Administration com_content com_languages Language & Strings Layout Libraries
avatar ITPrism
ITPrism - comment - 7 Feb 2018

Here you are subnavigation on the view Languages Overrides. :)

languages_overrides

avatar dgt41
dgt41 - comment - 7 Feb 2018

And as you see you're missing something there:
screen shot 2018-02-07 at 23 00 45

Obviously I'm not against this (i like it, I think @ciar4n already had a mock up months ago) but this needs a decision if it's ok to break 3rd PD code and dictate to only use the new filters.
Good job here!

avatar brianteeman
brianteeman - comment - 7 Feb 2018

Just a note that the language overrides screen is the only one remaining that was not converted to use "search tools" See #11976

avatar ITPrism
ITPrism - comment - 8 Feb 2018

No one force the developers to replace the sidebar with "search tools". The sidebar still exists and everyone will be able to implement it in their extensions.

avatar dgt41
dgt41 - comment - 9 Feb 2018

No one force the developers to replace the sidebar with "search tools"

Well that was the reason @ciar4n didn't implement his mockup. Forcing people to use only the new way for filters is something that needs to be decided. I guess @wilsonge and @mbabker needs to give some feedback here

avatar mbabker
mbabker - comment - 9 Feb 2018

We didn't 100% force Search Tools in part because Hathor didn't support it. I think with 4.0 we can re-evaluate if we need to keep supporting two ways of handling search filters or sidebar navigation and cut the duplication if appropriate.

I will say though that these toolings very heavily favor if you're using the "classic" MVC stack in your extension. If you're using your own RAD or the "no MVC" stack implementing these features isn't the easiest thing to do (I did pull it off in https://github.com/joomla-extensions/patchtester/blob/master/administrator/templates/atum/html/com_patchtester/pulls/default.php but it feels ugly to say the least).

avatar Samgithub1997
Samgithub1997 - comment - 22 Mar 2018

I have tested this item ? unsuccessfully on fcd5e88

When you click on categories or featured articles or fields or field groups , the UI is same as standard Joomla 4 (sidebar). The UI suggested by @ITPrism (Navigation bar) is only functional for Articles.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19590.

avatar Samgithub1997 Samgithub1997 - test_item - 22 Mar 2018 - Tested unsuccessfully
avatar mbabker
mbabker - comment - 22 Mar 2018

That's not an unsuccessful test. This is a proof of concept PR and it did not change every component view.

avatar Samgithub1997
Samgithub1997 - comment - 22 Mar 2018

I have tested this item successfully on fcd5e88

The UI suggested by @ITPrism (Navigation bar) is only functional(successful) for Articles. The changes haven't been added for all component views.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19590.

avatar Samgithub1997 Samgithub1997 - test_item - 22 Mar 2018 - Tested successfully
avatar mbabker
mbabker - comment - 21 Jul 2018

Still relevant given the new iteration on the template and the discussion about dropping the sidebar in full?

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Jul 2018
Status Pending Information Required
avatar wilsonge
wilsonge - comment - 22 Jul 2018

We're going to remove the submenu in entirety (although it's not been done yet) - also see joomla/40-backend-template#454

avatar wilsonge wilsonge - close - 22 Jul 2018
avatar wilsonge wilsonge - change - 22 Jul 2018
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2018-07-22 00:50:03
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 22 Jul 2018

Thankyou for the concept though :) very much appreciated

Add a Comment

Login with GitHub to post a comment