? Pending

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
2 Feb 2018

Pull Request for Issue #19520

Summary of Changes

See here: http://codemirror.net/doc/releases.html
Although not mentioned on the releases page, the previous version had a Typo that caused syntax coloring of PHP code to stop working. This is fixed in the new version.

Testing Instructions

Use codemirror.

Expected result

It will work as usual.

Actual result

It works as usual.

Documentation Changes Required

No

avatar okonomiyaki3000 okonomiyaki3000 - open - 2 Feb 2018
avatar okonomiyaki3000 okonomiyaki3000 - change - 2 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2018
Category JavaScript External Library
avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

yeah so... I don't know why there are these conflicts. Can this be correct?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

Why three commits? I think there's something wrong with this branch. Wait.

avatar okonomiyaki3000 okonomiyaki3000 - change - 2 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-02 02:18:40
Closed_By okonomiyaki3000
Labels Added: ?
avatar okonomiyaki3000 okonomiyaki3000 - close - 2 Feb 2018
avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

That's more like it.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

Something is weird here. I reopened but it's still closed.

avatar Quy
Quy - comment - 2 Feb 2018

@mbabker Please fix tracker. Here is the error when attempting to open it:

422 RuntimeException
Invalid response from GitHub
avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

I just pushed some meaningless commits to see if it would trigger anything but no.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

So I suppose I'll abandon this one and put in a new PR.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 2 Feb 2018

OK, forget about this one, the real codemirror update is #19533

Add a Comment

Login with GitHub to post a comment