Feeling Lucky
?
[#19524] - Code mirror update
- Closed
- 2 Feb 2018
- Medium
- Build: staging
- # 19524
- Diff
- okonomiyaki3000:CodeMirror-Update
User tests: Successful: Unsuccessful:
Pull Request for Issue #19520
Summary of Changes
See here: http://codemirror.net/doc/releases.html
Although not mentioned on the releases page, the previous version had a Typo that caused syntax coloring of PHP code to stop working. This is fixed in the new version.
Testing Instructions
Use codemirror.
Expected result
It will work as usual.
Actual result
It works as usual.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript External Library |
okonomiyaki3000
- comment
- 2 Feb 2018
Why three commits? I think there's something wrong with this branch. Wait.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-02 02:18:40 |
| Closed_By | ⇒ | okonomiyaki3000 | |
| Labels |
Added:
?
|
||
okonomiyaki3000
- comment
- 2 Feb 2018
That's more like it.
okonomiyaki3000
- comment
- 2 Feb 2018
Something is weird here. I reopened but it's still closed.
okonomiyaki3000
- comment
- 2 Feb 2018
I just pushed some meaningless commits to see if it would trigger anything but no.
okonomiyaki3000
- comment
- 2 Feb 2018
So I suppose I'll abandon this one and put in a new PR.
yeah so... I don't know why there are these conflicts. Can this be correct?