? ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
21 Jan 2018

Pull Request for Issue # .

Summary of Changes

  • move the code to custom element
  • fix the session bug
    - remove the relative tests (will be added later on once we finish the first round of fields conversion to CE)
  • use namespaced classes in all the layouts (admin side only)

Testing Instructions

Go to Admin Global Configuration and test the send mail functionality

Expected result

Actual result

Preview

screen shot 2018-01-21 at 19 39 17

Documentation Changes Required

No

avatar dgt41 dgt41 - open - 21 Jan 2018
avatar dgt41 dgt41 - change - 21 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2018
Category Unit Tests Repository Administration com_admin
avatar dgt41 dgt41 - change - 21 Jan 2018
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2018
Category Unit Tests Repository Administration com_admin Administration com_config JavaScript Repository Unit Tests
df56f30 21 Jan 2018 avatar dgt41 init
d9d988a 21 Jan 2018 avatar dgt41 tests
avatar dgt41 dgt41 - change - 21 Jan 2018
Labels Added: ?
2be2b05 21 Jan 2018 avatar dgt41 es6
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jan 2018
Build staging 4.0-dev
avatar dgt41 dgt41 - change - 22 Jan 2018
The description was changed
avatar dgt41 dgt41 - edited - 22 Jan 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jan 2018

I have tested this item successfully on 6f414c8

Test using all 3 Mailers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19426.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 22 Jan 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 22 Jan 2018

@dgt41 did this PR also fix this issue?

screenshot from 2018-01-22 23-28-48

This issue occurs when a new user is created.
Here also there should be two warning.

avatar dgt41
dgt41 - comment - 22 Jan 2018

@Anu1601CS no, that issue is not related to front end, it’s php related

avatar dgt41 dgt41 - change - 23 Jan 2018
The description was changed
avatar dgt41 dgt41 - edited - 23 Jan 2018
avatar Anu1601CS
Anu1601CS - comment - 23 Jan 2018

@dgt41 can, I enable mail function and how?

avatar dgt41
dgt41 - comment - 23 Jan 2018

@Anu1601CS it’s not joomla function it’s the server, yes you can enable it but the instructions to do so are very specific on your AMP server

avatar Anu1601CS
Anu1601CS - comment - 23 Jan 2018

@dgt41 Thanks for the information.

avatar Anu1601CS
Anu1601CS - comment - 23 Jan 2018

I have tested this item successfully on e2c6f55


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19426.

avatar Anu1601CS Anu1601CS - test_item - 23 Jan 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jan 2018

I have tested this item ? unsuccessfully on e2c6f55

After PR applied click on Button "Send Test Mail" got no Info- or Error-Message; no Message in Console but:
bildschirmfoto 2018-01-24 um 08 14 39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19426.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Jan 2018 - Tested unsuccessfully
avatar Anu1601CS
Anu1601CS - comment - 24 Jan 2018

@franz-wohlkoenig please check on manual install of a patch.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jan 2018

@Anu1601CS what is meant by "manual install"?

avatar Anu1601CS
Anu1601CS - comment - 24 Jan 2018

Just download this patch and install. Because it's working for me, that's why I told you to check by manual install.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jan 2018

I have tested this item successfully on e2c6f55

How to:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19426.
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Jan 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jan 2018

Ready to Commit after two successful tests.

avatar dgt41
dgt41 - comment - 24 Jan 2018

@wilsonge your call

avatar wilsonge wilsonge - change - 1 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-01 23:52:01
Closed_By wilsonge
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - close - 1 Feb 2018
avatar wilsonge wilsonge - merge - 1 Feb 2018
avatar wilsonge
wilsonge - comment - 1 Feb 2018

@dgt41 next time can we keep the namespacing changes separate - makes reviewing 100x harder trying to separate things out

Add a Comment

Login with GitHub to post a comment