? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
21 Jan 2018

Summary of Changes

To better support localization and UI display in non-English languages, the client language code needs to be communicated to the IFW server. This PR adds that capability.

Testing Instructions

Code review only, the server is not yet aware of these changes and therefore there is no functionality to test.

avatar mbabker mbabker - open - 21 Jan 2018
avatar mbabker mbabker - change - 21 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2018
Category JavaScript Front End Plugins
avatar brianteeman
brianteeman - comment - 21 Jan 2018

thanks

avatar mbabker mbabker - change - 21 Jan 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 21 Jan 2018

Do we actually need to send RTL? Can't we imply it from the language?

avatar mbabker
mbabker - comment - 21 Jan 2018

Now that I've actually done the implementation on the server code and know what I'm working with, no, not needed.

avatar mbabker mbabker - change - 28 Jan 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-28 20:02:48
Closed_By mbabker
avatar mbabker mbabker - close - 28 Jan 2018
avatar mbabker mbabker - merge - 28 Jan 2018

Add a Comment

Login with GitHub to post a comment