Joomla! Issue Tracker | Joomla! CMS #19407

Fixed in Code Base
20 Jan 2018
Medium
Build: 4.0-dev
# 19407
Diff
dgt41:§4.0-dev-fix-ce

Pending

Pending hound Hound is busy reviewing changes... Details

User tests: Successful: Unsuccessful:

dgt41
19 Jan 2018

Pull Request for Issue #19403 .

Summary of Changes

use the proper polyfills
move the switcher to the proper folder

Testing Instructions

Apply and check the backend if alerts and switches are rendering ok

Expected result

Actual result

Documentation Changes Required

1b1429f 19 Jan 2018

fix custom elements

dgt41 - open - 19 Jan 2018

dgt41 - change - 19 Jan 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 19 Jan 2018

Category

⇒

JavaScript Repository Layout

dgt41 - comment - 19 Jan 2018

@infograf768 here you go

C-Lodder - comment - 19 Jan 2018

Please could you also replace

// Various variables
const rootPath = __dirname.replace('/build/build-modules-js', '');

with

// Various variables
const isWin = /^win/.test(process.platform);
const rootPath = isWin ? _dirname.replace('\\build\\build-modules-js', '') : _dirname.replace('/build/build-modules-js', '');

in all build/build-module-js/*.js files

Either that or I can do it with my PR later on tonight or tomorrow

infograf768 - comment - 19 Jan 2018

Much better. Could not apply all changes with eclipse, but I do get the switcher class OK.
The 3 files concerned are:

dgt41 - comment - 19 Jan 2018

@C-Lodder now that I see that code I’m thinking that was way to fast patch so let’s do it in one line. Once you have your pr I’ll post the code there, let’s get this merged as it’s kinda urgent

C-Lodder - comment - 19 Jan 2018

@dgt41 sure no worries. @wilsonge please merge

wilsonge - change - 20 Jan 2018

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2018-01-20 01:35:57
Closed_By		⇒	wilsonge
Labels	Added: ?

wilsonge - close - 20 Jan 2018

wilsonge - merge - 20 Jan 2018

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#19407] - [4.0] Fix ce breaks