[#19356] - [4.0] fixErrorInTemplateJS
- Fixed in Code Base
- 13 Jan 2018
- Medium
- Build: 4.0-dev
- # 19356
- Diff
- astridx:missingJSFile
User tests: Successful: Unsuccessful:
Pull Request for Issue # #19318.
Summary of Changes
I've corrected the assignment of the selected folder and added a minimized JS
Testing Instructions
Go to Template - Customize, click "new file", choose file-type, enter name, choose directory where new file should be stored. (See #19318)
Expected result
Ability to choose a directory.
Actual result
Clicking a directory takes you back to the Template-Customize screen.
Clicking "create" will put the new file in the template's root.
After applying this patch the new file is saved in the selected directory.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Title |
|
||||||
| Labels |
Added:
?
|
||
yes the whole file should be unified, the forEach() is better for J4
Should I open a new issue for this? This would complicate the testing of this PR
I would not bother with it, it has not much profit over simple for loop https://jsperf.com/for-vs-foreach/75
Here someone summarized the advantages and disadvantages very well:
https://stackoverflow.com/questions/43031988/javascript-efficiency-for-vs-foreach
First of all, I leave everything as it is, because I also prefer foreach.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-13 17:03:34 |
| Closed_By | ⇒ | wilsonge |
Updated title to show its for j4