? Pending

User tests: Successful: Unsuccessful:

avatar cn-tools
cn-tools
10 Jan 2018

Summary of Changes

if a extension use field type "subform" and the xml file is in the wrong directory, the displayed information contains now the used path to the xml file.

Testing Instructions

use any extension from JED who use field type "subform" and rename/remove the subform xml file.
i have seen this problem, as i developed my own addon on my test system.
But my extension is not online now and also do not have this problem anymore :)

Expected result

if this problem exists, i will see the path to the file additional if j! is in JDEBUG mode

Actual result

i only see, that the file cannot be found

Documentation Changes Required

i think here is no change to do but this should decide the pros of joomla :)

avatar cn-tools cn-tools - open - 10 Jan 2018
avatar cn-tools cn-tools - change - 10 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2018
Category Libraries
avatar mbabker
mbabker - comment - 10 Jan 2018

Just going to link to #13050 which was turned down because the UI should not be exposing file paths in error messages.

avatar brianteeman
brianteeman - comment - 10 Jan 2018

@mbabker this is only in debug mode so exposing the path should be ok shouldn't it?

avatar mbabker
mbabker - comment - 10 Jan 2018

Error message text should be consistent, so no, I would not introduce a conditional for debug mode.

This is the type of information that should be written to a logging resource, not displayed in plain text inside an alert box on a webpage.

avatar brianteeman
brianteeman - comment - 10 Jan 2018

Fair point about consistent messages.

avatar brianteeman
brianteeman - comment - 10 Jan 2018

Closing for the reasons stated by @mbabker above.

avatar brianteeman brianteeman - close - 10 Jan 2018
avatar brianteeman brianteeman - change - 10 Jan 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-01-10 14:22:37
Closed_By brianteeman
Labels Added: ?

Add a Comment

Login with GitHub to post a comment