? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
10 Jan 2018

Pull Request for Issue #12450 .

Summary of Changes

Use the right variable.

Testing Instructions

Go to Components > Smart Search.
Click Index button.
Check php error log.

Expected result

No notices/warnings.

Actual result

PHP Notice:  Undefined index: * in \administrator\components\com_finder\helpers\indexer\helper.php on line 332
PHP Warning:  in_array() expects parameter 2 to be array, null given in \administrator\components\com_finder\helpers\indexer\helper.php on line 332

Documentation Changes Required

none

avatar Quy Quy - open - 10 Jan 2018
avatar Quy Quy - change - 10 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jan 2018
Category Administration com_finder
avatar infograf768 infograf768 - test_item - 11 Jan 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 11 Jan 2018

I have tested this item successfully on d76e1d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19344.

avatar infograf768
infograf768 - comment - 11 Jan 2018

Also, the popup does not let know when the indexing is done. It remains blocked on this
screen shot 2018-01-11 at 08 26 39

avatar Quy
Quy - comment - 15 Jan 2018

@alikon @brianteeman You tested the initial PR #12450. Please test so it can be merged in v3.8.4. Thanks.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jan 2018

I have tested this item successfully on d76e1d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19344.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 16 Jan 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 16 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Jan 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 16 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-16 22:38:54
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 16 Jan 2018
avatar mbabker mbabker - merge - 16 Jan 2018

Add a Comment

Login with GitHub to post a comment