User tests: Successful: Unsuccessful:
This functionality was developed and released for Joomla 3.2 (https://community.joomla.org/blogs/leadership/install-from-web-and-jed-listings.html) over 4 years ago. Although the original intention was that this would be part of the core it was released as an external plugin. One of the main reasons for that decision was the belief by the PLT at the time that
There are, however, a few concerns that I have. Currently the https://appscdn.joomla.org/ site that hosts the server side of the app store code is hosted with Rochen. From my own tests, Rochen's networks can't handle the type of traffic that we hope the JoomlaAppStore will be receiving.
I think after 4 years it is fair to say that either those concerns were unfounded and/or they have been resolved by the hosts
Being an external plugin managed by a separate team can not be called a success. Requests for fixes have been very slow, there has been zero development for several years and there are multiple open issues that have had zero response from the IFW team for many years.
It is not installable in J4 (xml issue on the update server)
has lots of code that will not be needed in j4 (checking for hathor)
[ ] Adds IFW to the core
[ ] The plugin is now enabled by default in the last position
[ ] Removes code and references to hathor
[ ] With the plugin in the core then it can be more easily developed and things like the jquery dependencies can be removed
[ ] J3 will still use the decoupled plugin - no change there
[ ] Namespace
[ ] Jquery
[ ] Extract view to own file
Apply PR
Run the sql below (replacing #__ with your db prefix
INSERT INTO `#__extensions` (`extension_id`, `package_id`, `name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `manifest_cache`, `params`, `checked_out`, `checked_out_time`, `ordering`, `state`, `namespace`) VALUES
(486, 0, 'plg_installer_webinstaller', 'plugin', 'webinstaller', 'installer', 0, 1, 1, 0, '', '{"tab_position":"1"}', 0, '0000-00-00 00:00:00', 0, 0, '')
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings SQL Installation Postgresql JavaScript Front End Plugins |
Labels |
Added:
?
?
|
Category | Administration Language & Strings SQL Installation Postgresql JavaScript Front End Plugins | ⇒ | Repository Administration Language & Strings SQL Installation Postgresql JavaScript Front End Plugins |
Category | Administration Language & Strings SQL Installation Postgresql JavaScript Front End Plugins Repository | ⇒ | Repository Administration com_installer Language & Strings SQL Installation Postgresql JavaScript Front End Plugins |
A couple notes:
Because of an architectural decision in 2013, the remote server is rendering the markup shown in the backend UI. Without re-engineering things, markup for the 4.0 template will need to be added to that repo and we'll need to use something to communicate the right markup to render (we already send the Joomla version so we can probably use that).
All other media assets (CSS/JS) are self contained in the plugin. So feel free to do what you please with those.
@brianteeman I pushed ec441a5 onto this PR doing a round of updates for the plugin (tried to do it as a PR to your branch but GitHub kept 404'ing on the save action).
@brianteeman Check brianteeman#69 as that merges @dgt41 initial JavaScript with me debugging things to get it working. It ain't pretty but it doesn't have any JS errors now.
Years ago I re-wrote the plugin, but it couldn't be used because the JED API wasn't able to handle request as needed. It was and it is a stupid idea to render markup on the remote server. We shouldn't do this misstake again.
So now it seems to be working and we just have markup issues to resolve. I am not too familiar with the IFW server and what is the most sensible way forward now. Any suggestions?
[ ] Convert markup served by IFW server to bs4?
[ ] Add bs2 css to the plugin and keep the server code the same?
I started https://github.com/joomla-extensions/install-from-web-server/compare/j4-support to deal with the UI changes (the plugin already sends the CMS version information with each request, I'm just using that to make decisions on which templates to load now). The grid views are functional, need to work on the list views and single extension view next. I'm basically doing a quick and dirty BS2 -> BS3 -> BS4 type migration to get the markup sorted with default elements, someone with an eye for design can make things prettier later.
We shouldn't do this misstake again.
@rdeutz I think when we are in a state where we can rewrite the architecture, we should update everything all at once (the standalone plugin for 3.x and the core plugin in 4.x). Let's not work ourselves into a point where we're maintaining two versions of the architecture for the next 3 years. So for now, the "easiest" thing is to keep using the same architecture (with good and bad decisions involved in it) and adapt for the new major version.
@brianteeman For now I would call this a "ready to merge" state as the plugin itself is now fully functional and any further changes are just part of the rest of the refactoring of the CMS codebase for 4.x (i.e. the JavaScript decoupling from jQuery) or the work is happening outside the CMS and doesn't block work here.
thanks for minifying the script - it was on my todo list but i forgot after drowning my sorrows as a result of a meeting tonight
Check and merge brianteeman#70 please. Does a lot of the cleanup stuff that needed to happen anyway (I finished the server side layouts then figured I'd do another round of effort on the plugin to get it up to spec).
Shooting from the hip, the only real work left here before things are "clean":
client.js
fileclient.css
file though).Then at some point whenever JED supports it we should probably update the server's API queries into the JED to filter out extensions that aren't compatible with whatever major version is in use.
my 2c would be to merge now and do further improvements later
Agree wholly. I'll merge up the layout work to the live server after this PR is merged too so it's not completely busted.
thanks - i plan to check the server stuff tomorrow
I just pushed up the work for the layout changes. So now with this PR applied you should get the J4 optimized UI.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-20 18:50:37 |
Closed_By | ⇒ | wilsonge |
Merged as requested :)
Thanks!!
This will now at least load. Looks like there is still a js error which is completely beyond me.
@Fedik @dgt41 any help appreciated