[#19293] - [4.0] Rewrite stats in vanilla JS
- Fixed in Code Base
- 1 Feb 2018
- Medium
- Build: 4.0-dev
- # 19293
- Diff
- C-Lodder:stats
User tests: Successful: Unsuccessful:
Summary of Changes
- Rewrite the stats script in vanilla JS
- The the proper CE event to close alerts
- Throw an alerts when unable to connect to
developer.joomla.org
Testing Instructions
- Fresh installation or reset the Stats plugin to that you get a nice big blue alert.
- Click the link inside the text to display which stats will be submitted.
- Click on any of the 3 buttons
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Front End Plugins |
| Labels |
Added:
?
|
||
You removed the header stating that the js is for and its version - was that deliberate?
@brianteeman deliberate. I dont see that comment block in any other JS file so keep them consistent
it is present in 36/53 js files in j4 - my view is that it should be present in them all
I agree with @brianteeman
The hard part is to get the since in the old scripts that don't have it
The hard part is to get the since in the old scripts that don't have it
Don't worry about them. Just put a description in the doc block and be done with it. There are already plenty of PHP endpoints with bad tags, unless you really want to waste a Saturday chasing Git/SVN history leave it be.
I was only suggesting keeping the headers not searching for old ones ;)
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-01 22:40:53 |
| Closed_By | ⇒ | wilsonge |
@dgt41 done