User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Apply the patch and check in admin the template cassiopeia
Kudos to @brianteeman and Christiane Maier-Stadtherr for their help on the accessibility!
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Layout Front End Templates (site) |
Class is a reserved word in js we can’t use it to assign variables
I knew there would be a good reason - thanks
Labels |
Added:
?
|
Category | JavaScript Repository Layout Front End Templates (site) | ⇒ | JavaScript Repository Administration Language & Strings Layout Front End Templates (site) |
Labels |
Added:
?
|
So we do have the word close, will do that
For users of assistive technologies it is obvious that the first white box is for transparent and not for white
For the rest of us they both look white
perhaps the transparent one should be with a red line through it?
@brianteeman that's the css part that needs some improvement, but I guess since all these fields will be styled properly for the new template this can be postponed. Right now the css is just an improved (?) version of the old one I guess we can do better than that. Maybe @ciar4n has something good in his mind for this
Havent looked at the code yet but hope you used the dropdown code from tk
Dont know where the color swatch came from but
why are we converting hex to rgb?
Well I have no clue, that part was there and I just kept it. For sure we can throw it away
About the second one: what difference will it make the limegreen
from a hexadecimal colour code to some visual impaired? I have no answer here but we can make it work either ways (at least for the known colours)
The Colorado pallets is fixed in the library so finding their real names will be easy.
I would assume that saying lime green is more useful and meaningful than the hex (or RGB) string
Dam autocorrect. Colorado should have been color
How about the following logic:
if the hex is a known color (name exists either in the basic or extended names of https://www.w3.org/TR/2017/CR-css-color-3-20171205/) then use the name else fall back to announcing the hex code
The colour picker can use the pretty much the same code as the dropdown. Better yet, it can use it, period. Will explain on skype later
What exactly will a dropdown solve here?
A nice touch here would be if the available colors could be defined within the xml.
I'd be against using named colours. A user could source colours externally, copy/pasted from photoshop, sketch, a colour palette etc. And these will always be in HEX.
For the same reason I'd be against even converting HEX to a named colour (if exists) as a user may wish to copy and paste a colour from Joomla to an external source. Becomes a pain unless you can roll off the HEX of LavenderBlush from the top of their head
yes the colors can be defined although I don't know how the colors used are either from the xml or it falls back to a standard set.
See
<field
name="blabla"
type="color"
control="simple"
colors="#000000, #FFFFFF, #AAAAAA"
default=""
label="color"
/>
It seems if no colors are defined in the xml then the standard set is used. The above looks likes...
Very neat
On a somewhat related note, we could do with a place to list topics that need to be documented for J4.
@brianteeman if you got some spare time please check this one, now will amend the colour name for the known colors (according to the W3C extended colors list)
It looks like this:
seems ok
@Anu1601CS should be ok now
I have tested this item
I have tested this item
I tested this successful:
I was able to use a default value like #222222;
I could use the advanced mode control="advanced" and the simple mode.
I could use colors="brown, white" or colors="#AAAAAA, #000000, #FFFFFF" in simple mode.
I could use a description.
The color picker is not used in the template for changing any template colors up to now, right?
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
The color picker is not used in the template for changing any template colors up to now, right?
Yes that filed was just placed in the template for testing purposes
Getting Argument 1 passed to Joomla\CMS\HTML\HTMLHelper::webcomponent() must be of the type string, array given
.
Labels |
Added:
?
|
Can you fix conflicts here?
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-03 12:19:32 |
Closed_By | ⇒ | laoneo |
It doesn't work anymore. The selected color doesn't get saved as the select element is not updated.
Why is it clss and not class?