User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Joomla
namespace for functionsI've kept the jQuery ajax function as it is for now
Global Configuration
>> Permissions
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries JavaScript |
Labels |
Added:
?
|
Can we add 2 todo tasks here:
I already commented on the jQuery.ajax thingy
Bare in mind the badge is a completely separate table columns, so whats the plan for the custom element? Wrap the table in it or target the badge outside the element?
Last time I tried moving code from JHtml to a layout, I was told not to do it
Last time I tried moving code from JHtml to a layout, I was told not to do it
My rule of thumb is this. Deprecating the corresponding JHtml helper if you're moving stuff to layouts is fine. Having a JHtml helper whose code is literally this IMO isn't (aside from during the deprecation period):
public static function foo()
{
echo JLayoutHelper::render('foo');
}
Layouts and JHtml have two different override systems and if you're overriding JHtml the odds the right markup (layout) is being produced are slim to none. So better to leave things so that there is only one way of overriding, not two where one of them may not even be called.
Ok what jhtml code are we talking about here? This is a form field, check the pho file that you’re eding in this pr
Category | Libraries JavaScript | ⇒ | Administration com_config Libraries JavaScript |
Merged your commits. Will test tomorrow
@C-Lodder if you got time and into the mood to move this field into JLayouts then this might be a good starting point: https://github.com/joomla/joomla-cms/compare/3.9-dev...dgt41:§3.9-dev-field-rules?expand=1
PS: I postponed the work as I was expecting the tabs CE to be merged, which still is not
Not in any mood to do it now. This is all working now anyway
Yes but it's not overridable, Bootstrap hardcoded no matter what!
Anyways I'll do it and promote the js code to CE as this is a Field and all fields should be CE
Yes but it's not overridable
wrong
Drone restarted
I already did after your last merge but it doesn't help, still failing
Category | Libraries JavaScript Administration com_config | ⇒ | Administration com_config Libraries JavaScript Unit Tests |
@brianteeman and again please :)
Labels |
Added:
?
|
@brianteeman Yeah but sometimes it's has a hissy fit and and throws an error
restarted drone as requested
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-02 10:45:43 |
Closed_By | ⇒ | C-Lodder |
I have tested this item✅ successfully on 95ed319
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19278.