? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
3 Jan 2018

Pull Request for Issue # .

Summary of Changes

  • Fix the icon position
  • Rewrite some of the jQuery in vanilla JS
  • Use Joomla namespace for functions

I've kept the jQuery ajax function as it is for now

Testing Instructions

  1. In the backend, go to Global Configuration >> Permissions
  2. Change some of the permissions

Expected result

  • There shouldn't be any whitespace below the dropdowns
  • The icon should appear to the right hand side of the dropdown
  • The permissions should work the same as before
avatar C-Lodder C-Lodder - open - 3 Jan 2018
avatar C-Lodder C-Lodder - change - 3 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2018
Category Libraries JavaScript
avatar C-Lodder C-Lodder - change - 3 Jan 2018
Labels Added: ?
avatar Anu1601CS Anu1601CS - test_item - 3 Jan 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 3 Jan 2018

I have tested this item successfully on 95ed319


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19278.

avatar dgt41
dgt41 - comment - 3 Jan 2018

Can we add 2 todo tasks here:

  • create a jLayout for this field
  • Make this (the js) a custom element

I already commented on the jQuery.ajax thingy

avatar C-Lodder
C-Lodder - comment - 3 Jan 2018

Bare in mind the badge is a completely separate table columns, so whats the plan for the custom element? Wrap the table in it or target the badge outside the element?

Last time I tried moving code from JHtml to a layout, I was told not to do it

avatar mbabker
mbabker - comment - 3 Jan 2018

Last time I tried moving code from JHtml to a layout, I was told not to do it

My rule of thumb is this. Deprecating the corresponding JHtml helper if you're moving stuff to layouts is fine. Having a JHtml helper whose code is literally this IMO isn't (aside from during the deprecation period):

public static function foo()
{
    echo JLayoutHelper::render('foo');
}

Layouts and JHtml have two different override systems and if you're overriding JHtml the odds the right markup (layout) is being produced are slim to none. So better to leave things so that there is only one way of overriding, not two where one of them may not even be called.

avatar dgt41
dgt41 - comment - 3 Jan 2018

Ok what jhtml code are we talking about here? This is a form field, check the pho file that you’re eding in this pr

avatar joomla-cms-bot joomla-cms-bot - change - 4 Jan 2018
Category Libraries JavaScript Administration com_config Libraries JavaScript
avatar C-Lodder
C-Lodder - comment - 4 Jan 2018

Merged your commits. Will test tomorrow

avatar dgt41
dgt41 - comment - 4 Jan 2018

@C-Lodder if you got time and into the mood to move this field into JLayouts then this might be a good starting point: https://github.com/joomla/joomla-cms/compare/3.9-dev...dgt41:§3.9-dev-field-rules?expand=1

PS: I postponed the work as I was expecting the tabs CE to be merged, which still is not

avatar C-Lodder
C-Lodder - comment - 4 Jan 2018

Not in any mood to do it now. This is all working now anyway

avatar dgt41
dgt41 - comment - 4 Jan 2018

Yes but it's not overridable, Bootstrap hardcoded no matter what!
Anyways I'll do it and promote the js code to CE as this is a Field and all fields should be CE

avatar C-Lodder
C-Lodder - comment - 4 Jan 2018

Yes but it's not overridable

wrong

avatar rdeutz
rdeutz - comment - 6 Jan 2018

@C-Lodder javescript test are failing

avatar dgt41
dgt41 - comment - 6 Jan 2018

wrong

@C-Lodder so you expect me to write a plugin to override bootstrap mark up?
In that sense everything is overridable in Joomla, but it's not inline with the promise of separated logic and markup.

avatar C-Lodder
C-Lodder - comment - 7 Jan 2018

@rdeutz - can you restart drone please?

avatar brianteeman
brianteeman - comment - 7 Jan 2018

Drone restarted

avatar rdeutz
rdeutz - comment - 7 Jan 2018

I already did after your last merge but it doesn't help, still failing

avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2018
Category Libraries JavaScript Administration com_config Administration com_config Libraries JavaScript Unit Tests
avatar C-Lodder
C-Lodder - comment - 7 Jan 2018

@brianteeman and again please :)

avatar C-Lodder C-Lodder - change - 7 Jan 2018
Labels Added: ?
avatar brianteeman
brianteeman - comment - 7 Jan 2018

@C-Lodder each time you push something to the repo it starts again on its own afaik

avatar C-Lodder
C-Lodder - comment - 7 Jan 2018

@brianteeman Yeah but sometimes it's has a hissy fit and and throws an error

avatar brianteeman
brianteeman - comment - 7 Jan 2018

restarted drone as requested

avatar C-Lodder C-Lodder - change - 2 Feb 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-02-02 10:45:43
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 2 Feb 2018

Add a Comment

Login with GitHub to post a comment