[#19246] - [4.0] Highlighter JS improvements
- Closed
- 2 Feb 2018
- Medium
- Build: 4.0-dev
- # 19246
- Diff
- C-Lodder:highlight
- Pending continuous-integration/drone/pr this build is pending Details
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR removes the inline JS for the smart search highlighter and also removes 90% of the jQuery.
There's still a couple more lines of jQuery left to rewrite, however I wasn't sure how to test that specific function.
Testing Instructions
- Create a smart search module and assign it to a page.
- Type a word in the input field and press Enter.
- Ensure the words on the results page are highlighted
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript |
| Labels |
Added:
?
|
||
1000 lines?
This could really be done in less than 100 lines. No idea why the scripts try to over complicate something so simple.
1000 lines?
I'm using an ES5 script specific for highlighting, most of the code is not mine there (not more than 100 lines, the ce part)
Why use an external script for that? Better check the possibilities in their site: https://markjs.io
@C-Lodder can you move this to custom element, here is something I was working on (based on markjs):1dd6004#diff-be30cdb278d8422fc9a70a5067ebf1bd
Yeah can do. Not doing any CE stuff till your PR to remove Grunt is merged though
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-02 10:45:04 |
| Closed_By | ⇒ | C-Lodder |
@C-Lodder please check: https://codepen.io/dgt41/pen/ZaKLbg this removes 100% of jquery and it's a custom element ;)