Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19218] - [4.0] Fix script imports on error pages

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
29 Dec 2017

Pull Request for Issue #18599

Summary of Changes

This PR fixes the paths of the scripts for error pages, both in the backend and frontend

avatar C-Lodder C-Lodder - open - 29 Dec 2017
avatar C-Lodder C-Lodder - change - 29 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2017
Category ⇒ Administration Templates (admin) Libraries Front End Templates (site)
avatar wilsonge wilsonge - close - 30 Dec 2017
avatar wilsonge wilsonge - merge - 30 Dec 2017
avatar wilsonge wilsonge - change - 30 Dec 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-12-30 16:51:37
Closed_By ⇒ wilsonge
Labels Added: ?
avatar dgt41
dgt41 - comment - 30 Dec 2017

The custom elements should not be loaded with script tags and not as es5. This will not work! Anyways I will provide the correct fix for this

avatar C-Lodder
C-Lodder - comment - 30 Dec 2017

@dgt41 - We can't use HTMLHelper because we're not injecting anything into the <head> in this file, unlike the template's index.php. As far as I remember, this wasn't possible with the error file, hence why I did it with a <script> tag

avatar dgt41
dgt41 - comment - 30 Dec 2017

@C-Lodder well I wasn't thinking of JHtml, check #19235

By the way thanks for doing this in the first place ?

Add a Comment

Login with GitHub to post a comment