[#19216] - [4.0] php 7.2 compatibility
- Closed
- 14 Feb 2018
- Medium
- Build: 4.0-dev
- # 19216
- Diff
- brianteeman:72count40
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Due to a change With php 7.2 the control panel shows several errors with the article related modules
Warning: count(): Parameter must be an array or an object that implements Countable in C:\Apache24\htdocs\cms4\administrator\components\com_content\Model\ArticlesModel.php on line 307
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
OK will leave open for now and hope that @wilonge brings 4.0 upto date and then if not needed then this can be closed
Shame that person doesn't exist on github :P cause sounds like a tough one for him :) (i'll get on it tomorrow)
| Labels |
Added:
?
|
||
i'll get on it tomorrow)
Is it tomorrow yet?
Kinda - i got 3.8.3 merged as of Tuesday and I've made a start on 3.8.5 locally
In fact actually it is
joomla-cms/administrator/components/com_content/Model/ArticlesModel.php
Lines 302 to 305 in 9b719ee
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-14 16:54:04 |
| Closed_By | ⇒ | wilsonge |
Thanks for the prod tho!
Since #18438 was merged this should be fixed by branch merging staging -> 3.9 -> 4.0. GitHub says the 4.0 branch is 130 commits behind staging right now so there's a bit of work waiting whenever the merge happens next.