? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
29 Dec 2017

This is a proper fix for: #19169

The PR simply moves the logic that sets the left position for the toolbar when the sidebar doesn't exists or is collapsed.

avatar C-Lodder C-Lodder - open - 29 Dec 2017
avatar C-Lodder C-Lodder - change - 29 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2017
Category JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Dec 2017

I have tested this item successfully on e49ce5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19212.

avatar Anu1601CS Anu1601CS - test_item - 29 Dec 2017 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 29 Dec 2017

I have tested this item successfully on e49ce5f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19212.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Dec 2017

Ready to Commit after two successful tests.

avatar Anu1601CS
Anu1601CS - comment - 29 Dec 2017

@C-Lodder Ok, Thanks for PR.I also think same logic to fix this issue after my first attempt.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19212.

avatar wilsonge wilsonge - change - 2 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-02 21:54:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Jan 2018
avatar wilsonge wilsonge - merge - 2 Jan 2018

Add a Comment

Login with GitHub to post a comment