Feeling Lucky
?
[#19177] - [CS] Code Style round 1 fixes for libraries/scr
- Fixed in Code Base
- 13 Jan 2018
- Medium
- Build: staging
- # 19177
- Diff
- photodude:PHPCS-LibrariesSrc
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- No blank line found after control structure
- Please consider an empty line before the if statement
- Please consider an empty line before the foreach statement
- Expected 1 space before "?"; 0 found
- Expected 1 space after ":"; 0 found
- Please consider an empty line before the return statement
- Fix some BlockComments
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
zero-24
- comment
- 13 Jan 2018
Merged on review. Thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-13 12:22:38 |
| Closed_By | ⇒ | zero-24 |
I have tested this item✅ successfully on d9e944b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19177.