Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19176] - [CS] Code Style fixes for plugins/

? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
26 Dec 2017

Pull Request for Issue code style fixes

Summary of Changes

  • Please consider an empty line before the return statement;
  • Please consider an empty line before the try statement;
  • block comments start and end with /* and */ and no text

Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers

None of the manual only fixes have been applied

Testing Instructions

Merge by code review

Expected result

code style has been applied as listed above, old code style testing on drone does not error.

Actual result

code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style

Documentation Changes Required

none

avatar photodude photodude - open - 26 Dec 2017
avatar photodude photodude - change - 26 Dec 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Dec 2017
Category ⇒ Front End Plugins
avatar Quy Quy - test_item - 26 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 26 Dec 2017

I have tested this item ✅ successfully on 17128b5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19176.

avatar wilsonge wilsonge - close - 10 Jan 2018
avatar wilsonge wilsonge - merge - 10 Jan 2018
avatar wilsonge wilsonge - change - 10 Jan 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-10 00:39:27
Closed_By ⇒ wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment