Feeling Lucky
?
[#19174] - [CS] Code Style fixes for components/
- Fixed in Code Base
- 27 Dec 2017
- Medium
- Build: staging
- # 19174
- Diff
- photodude:PHPCS2-components
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes.
Summary of Changes
- Blank line found at start of control structure
- No blank line found after control structure
- Expected 1 space before "?"; 0 found
- Expected 1 space after "="; 2 found
- Expected 0 spaces before closing bracket; 1 found
- Please consider an empty line before the if statement;
- Please consider an empty line before the switch statement
- Please consider an empty line before the foreach statement
- Line indented incorrectly
- Please consider an empty line before the return statement;
- New line between unrelated comments
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config com_contact com_content com_finder com_newsfeeds com_tags com_users |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-27 20:30:32 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 58ab8be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19174.