Feeling Lucky
?
[#19173] - [CS] Code Style fixes for administrator/components,modules,templates
- Fixed in Code Base
- 10 Jan 2018
- Medium
- Build: staging
- # 19173
- Diff
- photodude:PHPCS2-admin
User tests: Successful: Unsuccessful:
Pull Request for Issue code style fixes
Summary of Changes
- Please consider an empty line before the try/foreach statement
- Whitespace found at end of line
- Expected 1 space after "="; 2 found
- Expected 1 space before "="; 0 found
- Please consider an empty line before the return statement;
- Expected 1 newline after opening brace; 2 found
- Blank line found at start of control structure
- Please consider an empty line before the if statement;
- Line indented incorrectly;
Automatically fixed with Joomla code standards 2.0.0 PHPCS2-alpha2 fixers
None of the manual only fixes have been applied
Testing Instructions
Merge by code review
Expected result
code style has been applied as listed above, old code style testing on drone does not error.
Actual result
code style had not been applied. Autofixers from the Joomla code standards 2.0.0 PHPCS2 alpha2 were used to implement fixable code style
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_categories com_contact com_content com_fields com_installer Modules Templates (admin) |
| Title |
|
||||||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-10 00:43:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c30373f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19173.