@franz-wohlkoenig There is no entry for this PR in Joomla! Issue Tracker.

true, havent't found it too.

@mbabker?

It's there as far as I can tell
https://issues.joomla.org/tracker/joomla-cms/19100

I have tested this item ✅ successfully on 71a09d1

@photodude correct, now is there.

It just didn't get saved into the database as a PR, that's all. Fixed, all is well.

@franz-wohlkoenig Fixed e8a2874

@Quy what you wan't me to do by "Fixed e8a2874"?

I am not able to close this PR.

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/19100

closed as stated above.

Looks like @rdeutz overlooked this PR before just fixing the issue.
At least it's fixed.

oh sorry, I have seen it on the ci logs and fixed it

@rdeutz Same reason I opened the PR. It needed to be fixed.
Sadly Drone sometimes has odd issues and the CS issues get overlooked, which then look like drone is having issues rather than finally reporting the problems.

Working on trying to get the PHPCS 2 version of the ruleset with autofixers ready for release. Sadly the 1.5.x ruleset doesn't catch most issues. These are the errors I get with the 2.x ruleset

----------------------------------------------------------------------
A TOTAL OF 4671 ERRORS AND 255 WARNINGS WERE FOUND IN 790 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 3526 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

drone and github have a problem with getting the last state of the repo, it is in the works, but it is some kind of undocumented feature. So I am monitoring drone and restarting failed builds, hope this get sorted out soon :-)

For testing I would use the docker image we are using for PHPCS (https://github.com/joomla-projects/docker-phpcs) update it to a new version of phpcs and go from this state

For the moment I'm testing locally to get an exclusion list for the 2.x ruleset. For some reason, I'm having issues with the 2.x exclusion ruleset for the cms on Travis. On Travis the 2.x exclusion ruleset doesn't find any files to test, whereas the full ruleset works just fine. Locally both work correctly.

Docker is something I would like to do. At somepoint I really need to spend the time to learn how to work with it (along with vagrent for a consistant devbox and so everything isn't installed in my root OS).

Don't spend too much time on travis the long term goal is to use docker/drone

Travis was a means to an end, my local command prompt wouldn't log the full report of the errors. I've since switched to logging the errors to a file.

Just a note, PHPCS help me determine the issue with Travis see this issue. They told me that similar issues have been reported with Docker, the root cause is related to our ruleset exclude list. the exclude lists are a type of regex and our ruleset tripped because the build folder is excluded in the ruleset and travis uses "build" as part of the path directory.

The fix will be incorporated into the ruleset so hopefully, docker never has this issue.